Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the date picker label consistent with the time picker's #8086

Closed
valadzhov opened this issue Sep 3, 2020 · 0 comments · Fixed by #8088
Closed

Make the date picker label consistent with the time picker's #8086

valadzhov opened this issue Sep 3, 2020 · 0 comments · Fixed by #8088
Assignees
@Lipata @valadzhov
Labels
📅 date-picker size: S 🧰 feature-request version: 10.2.x ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.

Comments

@valadzhov
Copy link
Collaborator

valadzhov commented Sep 3, 2020 •
edited
Loading

Is your feature request related to a problem? Please describe.

The date picker's label implementation should be made consistent with how the time picker's one is implemented.

Describe the solution you'd like

It shouldn't be a property inside the component but a separate tag.

<igx-date-picker>
    <label igxLabel>Custom label</label>
</igx-date-picker>
@valadzhov valadzhov mentioned this issue Sep 3, 2020
Closed
valadzhov added a commit that referenced this issue Sep 3, 2020
@valadzhov
feat(date-picker): Rewiriting the label, #8086
6cdc617
@valadzhov valadzhov mentioned this issue Sep 3, 2020
Merged
14 tasks
valadzhov added a commit that referenced this issue Sep 3, 2020
@valadzhov
feat(date-picker): Fixing the tests, #8086
ec23445
valadzhov added a commit that referenced this issue Sep 8, 2020
@valadzhov
feat(date-picker): Removing labelVisibility from a couple of samples, #…
e48f5de 
…8086
valadzhov added a commit that referenced this issue Sep 9, 2020
@valadzhov
feat(date-picker): Updating the readme and the changelog, #8086
1442226
@valadzhov valadzhov added ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged. and removed 🛠️ status: in-development Issues and PRs with active development on them labels Sep 9, 2020
@valadzhov valadzhov assigned Lipata and unassigned damyanpetev Sep 9, 2020
valadzhov added a commit that referenced this issue Sep 15, 2020
@valadzhov
feat(date-picker): Fixing the tests, #8086
568f1a1
valadzhov added a commit that referenced this issue Sep 17, 2020
@valadzhov
feat(date-picker): Fixing the tests, #8086
220fd30
valadzhov added a commit that referenced this issue Sep 17, 2020
@valadzhov
feat(date-picker): Addressing comments, #8086
a01be33
valadzhov added a commit that referenced this issue Sep 17, 2020
@valadzhov
feat(date-picker): Fixing the template. #8086
869b9cc
valadzhov added a commit that referenced this issue Sep 17, 2020
@valadzhov
feat(date-picker): Changing the CHANGELOG. #8086
6806c48
valadzhov added a commit that referenced this issue Sep 18, 2020
@valadzhov
feat(date-picker): Restoring labelVisibility in the samples. #8086
9d8c7c9
valadzhov added a commit that referenced this issue Sep 18, 2020
@valadzhov
feat(date-picker): Breaking changes info. #8086
8fa55eb
valadzhov added a commit that referenced this issue Sep 18, 2020
@valadzhov
feat(date-picker): Fixing the samples. #8086
bf99739
valadzhov added a commit that referenced this issue Sep 18, 2020
@valadzhov
feat(date-picker): Cleaning the tests. #8086
0bbb182
Lipata pushed a commit that referenced this issue Sep 18, 2020
@valadzhov
feat(date-picker): content project the label #8086 (#8088)
6c66976
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Lipata Lipata

@valadzhov valadzhov

Labels
📅 date-picker size: S 🧰 feature-request version: 10.2.x ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(date-picker): content project the label, #8086 IgniteUI/igniteui-angular
3 participants
@Lipata @damyanpetev @valadzhov