Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Choose label -text for igxTimePicker #6905

Closed
AvanadeCermak opened this issue Mar 12, 2020 · 3 comments · Fixed by #8061 or #8103
Closed

Choose label -text for igxTimePicker #6905

AvanadeCermak opened this issue Mar 12, 2020 · 3 comments · Fixed by #8061 or #8103
Assignees
Labels
🕐 time-picker size: S 🧰 feature-request version: 10.2.x ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.

Comments

@AvanadeCermak
Copy link

Is your feature request related to a problem? Please describe.

The default Timepicker tag (without Template) has all that functionality but no way to change the lable. And if I use Templates there is no way to get the same functionality the default Timepicker has.

Describe the solution you'd like

Enable to choose the Labletext on TimePicker (like on DatePicker)
Or provide Timepicker -Template setup with the same Funktionality as the default TimePicker.

Additional context

Add any other context or screenshots about the feature request here.
image

@github-actions
Copy link

There has been no recent activity and this issue has been marked inactive.

@github-actions github-actions bot added the status: inactive Used to stale issues and pull requests label May 12, 2020
@Lipata Lipata removed the status: inactive Used to stale issues and pull requests label May 18, 2020
@github-actions
Copy link

There has been no recent activity and this issue has been marked inactive.

@github-actions github-actions bot added the status: inactive Used to stale issues and pull requests label Jul 18, 2020
@Lipata Lipata removed the status: inactive Used to stale issues and pull requests label Jul 19, 2020
@Lipata Lipata added the size: S label Aug 11, 2020
@radomirchev radomirchev added 🛠️ status: in-development Issues and PRs with active development on them and removed 🆕 status: new labels Aug 26, 2020
valadzhov added a commit that referenced this issue Aug 26, 2020
@damyanpetev damyanpetev added ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged. and removed 🛠️ status: in-development Issues and PRs with active development on them labels Sep 2, 2020
@valadzhov
Copy link
Collaborator

valadzhov commented Sep 3, 2020

Hi @AvanadeCermak
We've implemented a custom label functionality in the time picker which can be used in the following way:

<igx-time-picker>
    <label igxLabel>Custom label</label>
</igx-time-picker>

We chose to implement it this way in order for it to be consistent with the combo/select and also because it's more powerful than a text property.

It was also decided that the date picker's label will use this implementation, here is the feature request
All these changes will be present in our 10.2.0 release which is scheduled for October.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🕐 time-picker size: S 🧰 feature-request version: 10.2.x ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.
Projects
None yet
5 participants