Decouple device flow count from parameters #722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abouteiller
reviewed
Jan 2, 2025
| @@ -160,6 +160,24 @@ typedef int32_t parsec_dependency_t; | |||
| typedef int32_t parsec_dependency_t; | |||
| #endif | |||
|
|
|||
| #if ((MAX_PARAM_COUNT <= 128) || (PARSEC_MAX_DEVICE_FLOWS <= 128)) && defined(PARSEC_HAVE_INT128) | |||
There was a problem hiding this comment.
shouldn't this #if #elif sequence be in the reverse order so as to select the tightest possible representation (i.e., prefer 16 bits if the value is set to 16?)
There was a problem hiding this comment.
I reversed the order in which we choose the type so we pick the smallest possible type.
devreal
force-pushed
the
flow-mask-128bit
branch
from
91b0ef2 to
561854a
Compare
abouteiller
reviewed
Feb 14, 2025
| @@ -160,6 +160,24 @@ typedef int32_t parsec_dependency_t; | |||
| typedef int32_t parsec_dependency_t; | |||
| #endif | |||
|
|
|||
| #if ((MAX_PARAM_COUNT <= 16) || (PARSEC_MAX_DEVICE_FLOWS <= 16)) | |||
There was a problem hiding this comment.
Should be &&, we don't expect MAX_DEVICE_FLOW < MAX_PARAM_COUNT to be correct.
There was a problem hiding this comment.
Good catch, fixed 👍
Make PARSEC_MAX_DEVICE_FLOWS configurable and select a proper integer type, up to int128_t. Make sure the flow mask is properly checked. Signed-off-by: Joseph Schuchart <[email protected]>
devreal
force-pushed
the
flow-mask-128bit
branch
from
561854a to
e3a7829
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make PARSEC_MAX_DEVICE_FLOWS configurable and select a proper integer type, up to int128_t. Make sure the flow mask is properly checked.
This is an attempt at allowing an increase of the number of device inputs up to 128. The use of 128bit integers for flows requires proper handling of integer types so this PR introduces
parsec_flow_mask_tand provides macros to set and test the flow mask.Related: #694 where the flows are separated out of the gpu task structure.