Derive the device_task_t from a parsec_object_t #694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce the parsec_gpu_flow_info_s info structure to combine the flow information needed by the GPU code. Allow the standard device tasks (aka. parsec_gpu_dsl_task_t) to contain the flow_info array inside the task, while allowing other DSL to have their own type of device task (derived from parsec_gpu_task_t) Enhance the mechanism to release the device tasks via the release_device_task function pointer. The device code will call this function to let the DSL decide how to device task release should be handled. Some DSL (PTG and DTD as of now) will call OBJ_RELEASE on it (and the free is automatic), while others (TTG as an example) will have its own handling. Signed-off-by: George Bosilca <[email protected]>
abouteiller
reviewed
Dec 11, 2024
Co-authored-by: Aurelien Bouteiller <[email protected]>
abouteiller
previously approved these changes
Dec 12, 2024
This comment was marked as resolved.
This comment was marked as resolved.
abouteiller
added
the
API Change
abouteiller
added a commit
to abouteiller/dplasma
that referenced
this pull request
Jan 2, 2025
1 task
This comment was marked as resolved.
This comment was marked as resolved.
|
New problem: all tests with 2gpus appear to leak/over-retain gpu memory |
devreal
added a commit
to devreal/ttg
that referenced
this pull request
Jan 9, 2025
With ICLDisco/parsec#694 PaRSEC will support dyanmically allocated flows based on the application-managed gpu task structure. This allows us to ditch the extra task class structure and lets us cut down loops over MAX_PARAM_COUNT. Signed-off-by: Joseph Schuchart <[email protected]>
devreal
added a commit
to devreal/ttg
that referenced
this pull request
Jan 9, 2025
With ICLDisco/parsec#694 PaRSEC will have a proper initializer for gpu task structures but until then we need to properly initialize this field to something non-zero. Signed-off-by: Joseph Schuchart <[email protected]>
devreal
requested changes
Jan 10, 2025
| gpu_task->prof_tp_id = 0; | ||
| #endif | ||
| gpu_task->ec = NULL; | ||
| gpu_task->last_data_check_epoch = 0; |
There was a problem hiding this comment.
This is wrong because it will deadlock on the first GPU task submitted.
Suggested change
| gpu_task->last_data_check_epoch = 0; | |
| gpu_task->last_data_check_epoch = (uint64_t)-1; |
|
This is now used in TESSEorg/ttg#307 and seems to work (except for #694 (comment)). I'd like to see this go in asap. |
|
I saw a notification with a lldb stack trace but I can't find it here. Weird! Anyway, it seemed to indicate that the |
|
abouteiller
reviewed
Feb 13, 2025
| " gpu_task->ec = (parsec_task_t*)this_task;\n" | ||
| " gpu_task->submit = &%s_kernel_submit_%s_%s;\n" | ||
| " gpu_task->task_type = 0;\n" | ||
| " gpu_task->task_type = PARSEC_GPU_TASK_TYPE_KERNEL;\n" | ||
| " gpu_task->last_data_check_epoch = -1; /* force at least one validation for the task */\n", |
abouteiller
reviewed
Feb 13, 2025
| parsec_gpu_task_t *gpu_task = (parsec_gpu_task_t *) calloc(1, sizeof(parsec_gpu_task_t)); | ||
| PARSEC_OBJ_CONSTRUCT(gpu_task, parsec_list_item_t); | ||
| gpu_task->release_device_task = free; /* by default free the device task */ | ||
| parsec_gpu_task_t *gpu_task = (parsec_gpu_task_t*)PARSEC_OBJ_NEW(parsec_gpu_dsl_task_t); | ||
| gpu_task->ec = (parsec_task_t *) this_task; | ||
| gpu_task->submit = dtd_tc->gpu_func_ptr; | ||
| gpu_task->task_type = 0; | ||
| gpu_task->last_data_check_epoch = -1; /* force at least one validation for the task */ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce the parsec_gpu_flow_info_s info structure to combine the flow information needed by the GPU code.
Allow the standard device tasks (aka. parsec_gpu_dsl_task_t) to contain the flow_info array inside the task, while allowing other DSL to have their own type of device task (derived from parsec_gpu_task_t)
Enhance the mechanism to release the device tasks via the release_device_task function pointer. The device code will call this function to let the DSL decide how to device task release should be handled. Some DSL (PTG and DTD as of now) will call OBJ_RELEASE on it (and the free is automatic), while others (TTG as an example) will have its own handling.