-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix_test_data #442
fix_test_data #442
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I Upload the test data (after download) click visual inspection and use data it crashes
Is this why you opened #441 ? You assigned me - happy to do it but would do it on this branch, ok?
Also as mentioned in #428 we wanted to clear up intention - aka it should still have the warning, pass VI and be able to be used, correct?
Error for reference:
[1] "Data Input done"
Warning in file(file, "rt") :
cannot open file 'www/8bdaf581f94c56c8cb21dee6139ab25f/updatedMatrix.csv': No such file or directory
Warning: Error in file: cannot open the connection
100: file
99: read.table
98: read.csv
97: read_file [R/util.R#74]
96: eventReactiveValueFunc [/Users/lea/sciebo/Home/current/projects/HighSalt/program/shinyApp/server.R#1163]
52: data_input_shiny
45: observe [/Users/lea/sciebo/Home/current/projects/HighSalt/program/shinyApp/server.R#463]
44: <observer>
1: runApp
Yes, that's why I assigned you. You can do it on this branch 👍🏼
Yes 👍🏼 I think the intention is mostly cleared up with the Optional/required tests, thus |
Now: If passedVI is True, data from upload directly taken, if passedVI wrong - pop up error triggered, use data triggers the same error, If passedVI is turned from treu to false with our internal adjusmtents new variable changedDuringVI is set to true and changed data is used |
(not on purpose on this branch but should not harm)..Sorry
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Error when using test data -> Inspect data -> Use Data -> No Preprocessing -> Sig Ana (default values of cell). Error message
This is caused by either one of the mean values being 0 or by NAs in the testing.Warning: Error in seq.default: 'from' must be a finite number
86: stop
85: seq.default
83: create_new_tab_manual [R/significance_analysis/util.R#209]
82: create_new_tab [R/significance_analysis/util.R#27]
81: observe [R/significance_analysis/server.R#334]
80: observer:observeEvent(sig_ana_reactive$start_analysis)
1: shiny::runApp
The directory has been successfully removed.
Otherwise works fine (would not review code in depth as i will probably work on it soon anyways Two small remarks that are minor ones (perhaps not even needed):
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NOTE - we now changed the test data matrix having no NA
Found an Error in the Data that was responsible for the count matrix warning.
As far as i can see, the other warning comes from the annotation that has not been 100%. Workaround could be: