Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review comments #5 - Sig Ana Table #432

Open
PaulJonasJost opened this issue Jan 24, 2025 · 1 comment
Open

Review comments #5 - Sig Ana Table #432

PaulJonasJost opened this issue Jan 24, 2025 · 1 comment
Assignees
@LeaSeep
Labels
fixed but not released Solved the issue but still in develop branch. question / discussion

Comments

@PaulJonasJost
Copy link
Collaborator

Suggested Improvement by color.

My Idea:
Color in exactly the same way as Volcano Plots to create recognizable patterns between the two
@PaulJonasJost PaulJonasJost self-assigned this Jan 24, 2025
@LeaSeep LeaSeep assigned LeaSeep and unassigned PaulJonasJost Jan 31, 2025
LeaSeep added a commit that referenced this issue Feb 3, 2025
@LeaSeep
formatted data tables nicer according to #432
147e4e1
@LeaSeep
Copy link
Collaborator

LeaSeep commented Feb 3, 2025

  • added stars based on padj level (depending on user-sig ana level as well)
  • added color gradient to LFC (low and high correpsonding to Volcano)
  • added color gradient to padj and pvalue (gold to white - all white if > then user threshold
  • hide multiple columns for declutter able to select/deselect chosen columns
  • disallow filterig for 'stars' as filter gave raw HTML code as categories -looked ugly

@LeaSeep LeaSeep added the fixed but not released Solved the issue but still in develop branch. label Feb 3, 2025
LeaSeep added a commit that referenced this issue Feb 5, 2025
@PaulJonasJost @LeaSeep
fix_test_data (#442)
a36e58c 
* Fixed a wrong artifact in test data (compared with original data on geo base)
* Removed the upload data button in visual inspection and merged with the "Inspect Data"
* bug fixed -  missing input if uploaded data can be used as it is
* formatted data tables nicer according to #432
* fix tables accounting for difference in manual tab and DEseq tab
* make default names clearer
* added note for missing icons upon download

---------

Co-authored-by: Lea@Mac <[email protected]>
Co-authored-by: Lea Seep <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LeaSeep LeaSeep

Labels
fixed but not released Solved the issue but still in develop branch. question / discussion
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@PaulJonasJost @LeaSeep