This repository has been archived by the owner on Jul 22, 2024. It is now read-only.
Release v1.2.0 #211
Merged
Release v1.2.0 #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* place holders comments for potential idempotent fixes - unmount and mount flow * Idempotent : if vol not exit fail + start add unit testing * Idempotent Mount func : fix NewControllerWithClient, refactor doMount to small functions and add unit test for them(phase1) * mount idempotent : fix mounter.Mount unit test and get fakes from ubiquity in glide * mount idempotent : full coverage of unit testing for controller.Mount() + fix bug - Fix bug - return error when slink removal failed - Convert os ops in Mount() to use the standard exec.os to allow mocking * mount idempotent: controller.Mount fix issues with PV dir removal and slink aspects + 100% UT coverage * In addition - for provisioner side of thing - just add logging for create and delete volume
glide update to use ubiquity dev branch
Fix typo in debug message & positional arguments in error (Dana review)
Merge v1.1.1 to dev branch (Add support for IBM Power Systems)
Apply gofmt fixes
Print also the fileInfo in the error in case the mountpath is not dir nor slink. (feedback from Ran Harel code review PR #177).
#177 : Improve error message for mount idempotent step.
* UB-624_Flex_should_not_write_log_into_flex_driver_director Signed-off-by: feihuang <[email protected]> * Signed-off-by: feihuang <[email protected]> * change log path to /tmp/log/ubiquity Signed-off-by: feihuang <[email protected]> * remove ubiquity logrotate Signed-off-by: feihuang <[email protected]> * Signed-off-by: feihuang <[email protected]> * change log dir and do logrotate internal Signed-off-by: feihuang <[email protected]> * Signed-off-by: feihuang <[email protected]> * Signed-off-by: feihuang <[email protected]> * Signed-off-by: feihuang <[email protected]> * Signed-off-by: feihuang <[email protected]> * To test, we need to use ubiquity branch fix/UB-624_Flex_should_not_write_log_into_flex_driver_directory will change back after test Signed-off-by: feihuang <[email protected]> * remove version after build a testing build Signed-off-by: feihuang <[email protected]> * Signed-off-by: feihuang <[email protected]> * Signed-off-by: feihuang <[email protected]> * Signed-off-by: feihuang <[email protected]> * Signed-off-by: feihuang <[email protected]> * Signed-off-by: feihuang <[email protected]> * Signed-off-by: feihuang <[email protected]> * add UT for load config Signed-off-by: feihuang <[email protected]> * Signed-off-by: feihuang <[email protected]> * add ginkgo ut Signed-off-by: feihuang <[email protected]>
Added request id + go routine id to provisioner and flex logs.
* Update to k8s 1.9 in glide * update k82-incubator/external-storage
* Fix idempotent issues in Unmount flex (slink exist, removal and no PV) + refactoring 1. fix idempotent1 if PV not exist in ubiqutiy DB then finish unmount with success 2. fix idempotent2 if slink not exist then skip unmount and go to detach stage (Add checkSlinkBeforeUmount func to identify the idempotent state and other abnormal slink states) 3. fix idempotent3 if slink not exist then do not try to delete it. 4. Refactor - fix backend identification by ubiquity server call rather then check by mountpoint path 5. Refactor - Unmount with doUnmount and removal the different flow for SSc (because it should be the same flow) * Add unit testing for Unmount * Refactor to reuse failureFlexVolumeResponse func * Fixed Olga code review comments
In this PR I wanted to update the new logging to the following state: in the ubiquity logger there we be shown the go routine id (and the pid will be removed from the log) : because the ubiquity server always runs in the same pid so no need to show it in the log since it does not give us any more information. in flex logger we will show the pid only (the go id routine will be removed) : since every flex request will always have the same go routine id there is not need to show both the request id and the go routine id. in provisioner log we will neither show the go routine id nor the pid of the process : since as for the flex logger each request will always have the same go routine id. and also like the ubiqity server the provisioner will always run with the same pid.
Cleanup old ubiquity provisioner installation method and refactor acceptance test dir
* UB-1098: change info messages to warning for idempotent issues *
…uses caching (#200) * Enable caching in Provisioner Dockerfile * Remove glide.lock from Dockerfile * Add all glide dependencies * Resolve conflicts in glide.yaml * remove glide.lock * Set ubiquity-k8s to be dependent on specific commit in ubiquity * Set versions in glide.yaml to eliminate warnings
#197) * UB-1001: fix idempotent issue : when calling detach with an empty host will return not attached response*
this PR will add an action name to each log line. (for example all oprerations that are part of Delete will have the request-action name in the log. like : fd5dd389-7acb-11e8-88cd-54ee75515403-Delete )
This PR is to not allow attachement of 2 pods to one PVC. currently this is allowed due to a fix of another idempotent issue. we are checking if a PVC is already attached to another pod using the slinks - in the mount process we check if the /ubiquity/volume is already linked to a pod that is not the current pod - if so then we will fail the mount process. also a mountlock is added to prevent operations during the mount happening for 2 different pods (and same PVC)
Fix/fixed glide file - align latest to specific commits (phase2)
This PR will allow the flex to continue with the unmount process even if the link from k8smointpath (/var/lib/kubelet/pods/a0929255-9b1a-11e8-9b44-005056a4d4cb/volumes/ibm~ubiquity-k8s-flex/pvc-ab512cc6-9b0f-11e8-9b44-005056a4d4cb) to the mountpoint (/ubiquity/WWN) is broken and the mountpoint does not exist.
…ing it as Volume not found (#236)
…f image versions (#207) * Update notices file for version 1.2 * ubiquity_installer.conf : update the image version 1.1.1 -> 1.2.0
shay-berman
commented
Aug 30, 2018
There was a problem hiding this comment.
Reviewed 55 of 55 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @beckmani and @olgashtivelman)
beckmani
approved these changes
Aug 30, 2018
There was a problem hiding this comment.
Reviewed 1 of 55 files at r1.
Reviewable status:
|
We have a green light to merge v1.2 to master. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the PR to merge GA v1.2.0 content from dev to master (via release branch named release_v1.2.0).
This PR related to the ubiquiy-k8s release PR IBM/ubiquity#245.
Here is the release content (The content will be mentioned also in the release tag description of v1.2.0):
New in this release
Expanded support matrix:
Support for Kubernetes v1.10 and v1.11.
Support for IBM Cloud Private v2.1.0.3. (Fix tolerations setting in flex daemonset to support also ICP v2.1.0.2+ #203)
Support for IBM Z architecture s390x (ubiquity related PRs).
Full Ubiquity DockerHub repositories are as follows (introducing the new s390x images):
Stability improvements:
Refactors:
This change is