Skip to content
This repository has been archived by the owner on Jul 22, 2024. It is now read-only.

Apply gofmt fixes #187

Merged
merged 1 commit into from
May 13, 2018
Merged

Apply gofmt fixes #187

merged 1 commit into from
May 13, 2018

Conversation

shay-berman
Copy link
Contributor

@shay-berman shay-berman commented May 9, 2018

Align the code with gofmt.
We carry many gofmt issues, and now is the time to fix them all.
We should make sure every Ubiquity developer set automatic gofmt in its IDE to prevent pushing formatting issues in the future.

We should keep go report in high score as much as possible.

This change is Reviewable

@shay-berman shay-berman self-assigned this May 9, 2018
@olgashtivelman
Copy link
Collaborator

Reviewed 6 of 6 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@olgashtivelman
Copy link
Collaborator

:lgtm:


Review status: all files reviewed at latest revision, all discussions resolved, all commit checks successful.


Comments from Reviewable

@shay-berman shay-berman merged commit 40b2290 into dev May 13, 2018
@shay-berman shay-berman deleted the fix/gofmt_alignment branch September 17, 2018 09:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants