Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ODBC Transport #51

Merged
merged 6 commits into from
Jun 6, 2019
Merged

Add ODBC Transport #51

merged 6 commits into from
Jun 6, 2019

Conversation

abmusse
Copy link
Member

@abmusse abmusse commented May 20, 2019

Part of the overall #26 issue.

@abmusse abmusse requested review from kadler, markdirish and ThePrez May 20, 2019 19:44
Copy link
Member

@ThePrez ThePrez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve once @kadler's concerns are addressed

@abmusse
Copy link
Member Author

abmusse commented May 31, 2019

@kadler

I have added the requested changes, is this PR looking good now?

If so I will squash the 2 latest commits.

@abmusse
Copy link
Member Author

abmusse commented May 31, 2019

@kadler
I have added the latest suggestions and squashed those changes.

Copy link
Member

@kadler kadler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@abmusse abmusse removed the request for review from markdirish May 31, 2019 21:29
@abmusse
Copy link
Member Author

abmusse commented May 31, 2019

Added connection.close() to close connection

...
    connection.close((closeError) => {
      if (closeError) {
        done(closeError, null);
        return;
      }

      if (!results) {
        done('Empty result set was returned', null);
        return;
      }

      let xmlOutput = '';

      results.forEach((chunk) => {
        xmlOutput += chunk.OUT151;
      });

      done(null, xmlOutput);
    });

@abmusse abmusse merged commit c0e80ff into IBM:v1.0-dev Jun 6, 2019
@abmusse abmusse deleted the odbc-transport branch May 8, 2020 02:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants