-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ODBC Transport #51
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I approve once @kadler's concerns are addressed
I have added the requested changes, is this PR looking good now? If so I will squash the 2 latest commits. |
@kadler |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Added connection.close() to close connection ...
connection.close((closeError) => {
if (closeError) {
done(closeError, null);
return;
}
if (!results) {
done('Empty result set was returned', null);
return;
}
let xmlOutput = '';
results.forEach((chunk) => {
xmlOutput += chunk.OUT151;
});
done(null, xmlOutput);
}); |
Part of the overall #26 issue.