Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add New Transports #26

Closed
2 of 3 tasks
abmusse opened this issue Jan 25, 2019 · 1 comment
Closed
2 of 3 tasks

Add New Transports #26

abmusse opened this issue Jan 25, 2019 · 1 comment
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@abmusse
Copy link
Member

abmusse commented Jan 25, 2019

I propose we add additional transports to the toolkit.

Currently the toolkit supports 2 transports REST and DB2 (calling idb-connector stored proceduce)

We can enhance the itoolkit by incorporating

  • ODBC transport
  • SSH transport
  • idb-pconnector (Explore ways of making use of connection pooling)

ODBC and SSH transports would allow users from non IBM i machines to use the itoolkit.

To do so we would need to update iConn constructor see #25

The current signature of iConn constructo (database, user, password [,restOptions]) will use rest transport when the fourth positional argument is an object.

Otherwise will use idb-connector as the transport.

Also we should move all transports under a single directory lib/transports

@abmusse abmusse self-assigned this Jan 25, 2019
@abmusse abmusse added the enhancement New feature or request label Jan 25, 2019
@abmusse abmusse added this to the Version 1.0 milestone Jan 25, 2019
@abmusse abmusse mentioned this issue Jan 30, 2019
9 tasks
@abmusse abmusse changed the title Add new transports Add SSH transport Apr 19, 2019
@abmusse abmusse changed the title Add SSH transport Add SSH Transport Apr 19, 2019
@abmusse abmusse changed the title Add SSH Transport Add New Transports May 20, 2019
@abmusse
Copy link
Member Author

abmusse commented Jun 13, 2019

ODBC and SSH transports added.

With the current design of itoolkit where transports open and close connections after each call to Connection.run() using Connection pooling from idb-pconnector opening and closing the pool would be very useful.

In the future, if we change our design to keep connections alive it would be very benefital to use idb-pconnector as a transport over idb-connector.

@abmusse abmusse closed this as completed Jun 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant