-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
First set of macro variables #56
Conversation
Sorry, the tags don't work like that, they have to be part of the variable-name - see the documentation here. About the currency-units, I strongly suggest to move towards SI/ISO-conventions and avoid special characters - this will greatly facilitate automated processing, validation and processing in subsequent applications. |
@danielhuppmann. I see, I undid that. Still, I don't understand the error raised in the checks now. I thought I was using the tags now as intended:
|
The following - Food:
description: COICOP code CP01 (Food) is interpreted as {
"Food": None,
"description": "COICOP code CP01 (Food)"
} You have to add two whitespaces before the description such - Food:
description: COICOP code CP01 (Food) is interpreted as {
"Food": {"description": "COICOP code CP01 (Food)"}
} |
Still, the validation creates errors. My suspicion is that I used tags inside tag definitions and that I'm not allowed to do that. |
Unfortunately, you are correct, it is not (yet?) possible to do nested tagging, but given that these are only four items, it works to include them directly, I guess? |
Also, I see that you used Final Energy as the standard method for aggregating carbon prices. Looking back at #38, I think we should make that explicit in the variable name how the price was computed. |
I did not find the common suggestion of Tier 1 we build @IAMconsortium/common-definitions-macro-economy |
Dear all, @danielhuppmann made me aware of this discussion. Regarding the Value Added | billion US$2010/yr | Total value added |
Very usefull Volker. We started to do it in PR57 e.g. This File I will also mention your comment in the general issue |
description: electricity | ||
- Secondary Energy|Hydrogen: | ||
description: hydrogen | ||
- Secondary Energy|Liquids|Biomass: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a category for (aggregate) liquid fuels
@orichters, is this PR still relevant? |
@FlorianLeblancDr and I added a first set of macro variables, still needs a review from @IAMconsortium/common-definitions-macro-economy, but I think let us already check whether we are going in the right direction now.
I tried to use tags as much as possible, but sometimes there is significant overlap between economic sectors used for Value Added, for Trade, for Energy etc., so it might be worth doing a cleanup.
@danielhuppmann: I'm not sure whether the Currency unit tag works like that, but I think it should. Haven't tested. Also unsure whether to use
billion USD_2010/yr
orbillion US$2010/yr