Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Level 2 of economic sectors - with ISIC definitions #279

Open
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

FlorianLeblancDr
Copy link
Contributor

@FlorianLeblancDr FlorianLeblancDr commented Feb 17, 2025

I introduced the level 2 of economic sector (variable Value Added only for now), building on ISIC classification.

I build on @volker-krey comments made in #56
Giving variable used in the National Scenario template:

  • level 3 categories (disaggregation of Industrial sub-sectors) are still missing
  • I kept the ISIC names: thus the broad category "Energy" caterogy defined there is under "Energy All Supply Chains" now. Please let me know what you think of it
  • I found it useful to add the Services "Commercial" sub-category, but did not disaggregated further services (will be done in level 3 as sub-categories or Others)

Please review @IAMconsortium/common-definitions-macro-economy

@FlorianLeblancDr FlorianLeblancDr marked this pull request as draft February 17, 2025 15:17
@FlorianLeblancDr FlorianLeblancDr requested a review from a team February 17, 2025 16:42
@FlorianLeblancDr FlorianLeblancDr marked this pull request as ready for review February 17, 2025 16:53
@FlorianLeblancDr
Copy link
Contributor Author

FlorianLeblancDr commented Feb 18, 2025

Bug are fixed
This PR is open for review now @IAMconsortium/common-definitions-macro-economy

Copy link
Member

@danielhuppmann danielhuppmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, a few comments inline.

- Employment|{Economic Sectors Level 2}:
description: Employment by the {Economic Sectors Level 2}
unit: Million full-time equivalent workers
tier: 1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this really have to be a tier-1 variable?

Also, the top-level "Employment" variable was renamed to "Labour Force|Employed" in common-definitions. Consider revising here as well, or add a note attribute to cross-reference to the total-employment variable.

@danielhuppmann
Copy link
Member

Please rebase this branch, and maybe also use this opportunity to copy all variables from macroeconomy_other.yaml to other relevant yaml files in the macro folder. Seems like there are now several files with a not-quite-obvious logic...

@FlorianLeblancDr
Copy link
Contributor Author

Done (rebase + sorting macroeconomic_other.yaml).
Any Idea how to deal with Employment variables?

I don't mind making sub-categories such as
Labour Force|Employed|{sectors}".

@FlorianLeblancDr FlorianLeblancDr marked this pull request as ready for review February 19, 2025 14:31
@FlorianLeblancDr
Copy link
Contributor Author

@danielhuppmann first time I rebase on github, seems now in the PR appears changes already in the upsteam
but I did not had yet in my fork (MESSAGE mappings). Hope this isn't bad

@FlorianLeblancDr
Copy link
Contributor Author

Rebase cleaned!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants