-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Level 2 of economic sectors - with ISIC definitions #279
base: main
Are you sure you want to change the base?
Level 2 of economic sectors - with ISIC definitions #279
Conversation
Bug are fixed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, a few comments inline.
definitions/variable/macro-economy/tag_economic_sectors_level-1.yaml
Outdated
Show resolved
Hide resolved
definitions/variable/macro-economy/tag_economic_sectors_level-1.yaml
Outdated
Show resolved
Hide resolved
definitions/variable/macro-economy/tag_economic_sectors_level-1.yaml
Outdated
Show resolved
Hide resolved
- Employment|{Economic Sectors Level 2}: | ||
description: Employment by the {Economic Sectors Level 2} | ||
unit: Million full-time equivalent workers | ||
tier: 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this really have to be a tier-1 variable?
Also, the top-level "Employment" variable was renamed to "Labour Force|Employed" in common-definitions. Consider revising here as well, or add a note
attribute to cross-reference to the total-employment variable.
definitions/variable/macro-economy/tag_economic_sectors_level-2.yaml
Outdated
Show resolved
Hide resolved
Please rebase this branch, and maybe also use this opportunity to copy all variables from |
Done (rebase + sorting macroeconomic_other.yaml). I don't mind making sub-categories such as |
@danielhuppmann first time I rebase on github, seems now in the PR appears changes already in the upsteam |
Co-authored-by: Daniel Huppmann <[email protected]>
def42d7
to
e59ff08
Compare
…initions into isic_sectors
Rebase cleaned! |
I introduced the level 2 of economic sector (variable Value Added only for now), building on ISIC classification.
I build on @volker-krey comments made in #56
Giving variable used in the National Scenario template:
Please review @IAMconsortium/common-definitions-macro-economy