Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix alpinejs discrepencies, typos in review score #4402

Merged
merged 1 commit into from
Feb 20, 2025
Merged

Fix alpinejs discrepencies, typos in review score #4402

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions hypha/apply/review/templates/review/review_edit_form.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,10 +20,10 @@

<div class="relative my-8" x-data="reviewScore">
<!-- Review score sticky display -->
<div class="hidden absolute top-0 right-0 h-full lg:block">
<div class="absolute top-0 right-0 h-full lg:block">
<div
class="inline-block sticky top-1 py-1.5 px-3 mt-1 font-semibold text-center text-white bg-arsenic"
x-clock
x-cloak
x-show="showScore"
>
{% trans "Score:" %} <span x-text="totalScore">-</span>
Expand Down Expand Up @@ -73,7 +73,7 @@ <h2>{{ value }}</h2>
</button>
{% endif %}

<div class="text-fg-muted" x-clock x-show="showScore">
<div class="text-fg-muted" x-cloak x-show="showScore">
{% trans "Total Score:" %} <span x-text="totalScore"></span>
</div>
</div>
Expand Down
6 changes: 3 additions & 3 deletions hypha/apply/review/templates/review/review_form.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,10 +30,10 @@
{% include "forms/includes/form_errors.html" with form=form %}

<section class="flex relative justify-between my-8" x-data="reviewScore">
<div class="hidden absolute top-0 right-0 h-full lg:block">
<div class="absolute top-0 right-0 h-full lg:block">
<div
class="inline-block sticky top-1 py-1.5 px-3 mt-1 font-semibold text-center text-white bg-arsenic float-end"
x-clock
x-cloak
x-show="showScore"
>
{% trans "Score:" %} <span x-text="totalScore">-</span>
Expand Down Expand Up @@ -74,7 +74,7 @@ <h2>{{ value }}</h2>
<button class="button button--primary min-w-48" type="submit" name="submit">
{% trans "Submit" %}
</button>
<div class="text-fg-muted" x-clock x-show="showScore">
<div class="text-fg-muted" x-cloak x-show="showScore">
{% trans "Total Score:" %} <span x-text="totalScore"></span>
</div>
</div>
Expand Down
Loading