Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix alpinejs discrepencies, typos in review score #4402

Merged
merged 1 commit into from
Feb 20, 2025

Conversation

frankduncan
Copy link
Contributor

alpinejs, when using x-show, doesn't need the element to be hidden, as it will take care of that. Also, x-clock should be x-cloak

Found this bug when I was merging our codebases together, and the score floating widget wasn't showing up. The one next to the submit buttons was though.

The floating score does interact somewhat poorly with the application when "Show Application" is viewed.

I didn't create an issue for this, let me know if you want me to!

alpinejs, when using x-show, doesn't need the element to be hidden, as
it will take care of that.  Also, x-clock should be x-cloak
@frjo frjo added Type: Bug Bugs! Things that are broken :-/ Type: Patch Mini change, used in release drafter labels Feb 20, 2025
@frjo
Copy link
Member

frjo commented Feb 20, 2025

@frankduncan Thanks for the bug fix!

@frjo frjo merged commit 1dfcdf8 into main Feb 20, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Bugs! Things that are broken :-/ Type: Patch Mini change, used in release drafter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants