Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated PR template to reflect testing practices #3729

Merged
merged 1 commit into from
Jan 18, 2024
Merged

Conversation

wes-otf
Copy link
Contributor

@wes-otf wes-otf commented Jan 18, 2024

Quick PR to update the PR template reflecting the testing conversations we had today

@frjo frjo added Type: Maintenance Type: Patch Mini change, used in release drafter labels Jan 18, 2024
@frjo frjo merged commit ac04e6e into main Jan 18, 2024
@theskumar theskumar deleted the update-pr-template branch January 18, 2024 07:15
theskumar added a commit that referenced this pull request Jan 29, 2024
* main:
  Remove public primary nav (db) and "news" app (#3715)
  Fix errors for compare revisions page(JSONDecodeError and Invalid literal int error) (#3727)
  Add dir attribute to the html tag, ltr/rtl. (#3728)
  docs: remove duplicate info at references > workflows (#3730)
  Updated PR template to reflect testing practices (#3729)
theskumar added a commit that referenced this pull request Jan 29, 2024
…' into maintainance/remove-partners-app

* origin/maintainance/remove-partners-app:
  Remove public "partners" app
  Remove public primary nav (db) and "news" app (#3715)
  Fix errors for compare revisions page(JSONDecodeError and Invalid literal int error) (#3727)
  Add dir attribute to the html tag, ltr/rtl. (#3728)
  docs: remove duplicate info at references > workflows (#3730)
  Updated PR template to reflect testing practices (#3729)
theskumar added a commit that referenced this pull request Jan 29, 2024
…emove-people-app

* maintainance/remove-partners-app:
  Remove public "partners" app
  Remove public primary nav (db) and "news" app (#3715)
  Fix errors for compare revisions page(JSONDecodeError and Invalid literal int error) (#3727)
  Add dir attribute to the html tag, ltr/rtl. (#3728)
  docs: remove duplicate info at references > workflows (#3730)
  Updated PR template to reflect testing practices (#3729)
theskumar added a commit that referenced this pull request Jan 29, 2024
…emove-projects-app

* maintainance/3-remove-people-app:
  Remove public "partners" app
  Remove public primary nav (db) and "news" app (#3715)
  Fix errors for compare revisions page(JSONDecodeError and Invalid literal int error) (#3727)
  Add dir attribute to the html tag, ltr/rtl. (#3728)
  docs: remove duplicate info at references > workflows (#3730)
  Updated PR template to reflect testing practices (#3729)
theskumar added a commit that referenced this pull request Jan 29, 2024
…-remove-public-forms-app

* maintainance/4-remove-projects-app:
  Remove public "partners" app
  Remove public primary nav (db) and "news" app (#3715)
  Fix errors for compare revisions page(JSONDecodeError and Invalid literal int error) (#3727)
  Add dir attribute to the html tag, ltr/rtl. (#3728)
  docs: remove duplicate info at references > workflows (#3730)
  Updated PR template to reflect testing practices (#3729)
theskumar added a commit that referenced this pull request Jan 29, 2024
…ce/6-remove-public-lab-round-page

* maintainance/5-remove-public-forms-app:
  Remove public "partners" app
  Remove public primary nav (db) and "news" app (#3715)
  Fix errors for compare revisions page(JSONDecodeError and Invalid literal int error) (#3727)
  Add dir attribute to the html tag, ltr/rtl. (#3728)
  docs: remove duplicate info at references > workflows (#3730)
  Updated PR template to reflect testing practices (#3729)
theskumar added a commit that referenced this pull request Jan 29, 2024
…ainance/7-remove-standard-pages

* maintainance/6-remove-public-lab-round-page:
  Remove public "partners" app
  Remove public primary nav (db) and "news" app (#3715)
  Fix errors for compare revisions page(JSONDecodeError and Invalid literal int error) (#3727)
  Add dir attribute to the html tag, ltr/rtl. (#3728)
  docs: remove duplicate info at references > workflows (#3730)
  Updated PR template to reflect testing practices (#3729)
theskumar added a commit that referenced this pull request Jan 29, 2024
…/8-cookie-settings

* maintainance/7-remove-standard-pages:
  Remove public "partners" app
  Remove public primary nav (db) and "news" app (#3715)
  Fix errors for compare revisions page(JSONDecodeError and Invalid literal int error) (#3727)
  Add dir attribute to the html tag, ltr/rtl. (#3728)
  docs: remove duplicate info at references > workflows (#3730)
  Updated PR template to reflect testing practices (#3729)
theskumar added a commit that referenced this pull request Jan 29, 2024
…pdates

* maintainance/8-cookie-settings:
  Remove public "partners" app
  Remove public primary nav (db) and "news" app (#3715)
  Fix errors for compare revisions page(JSONDecodeError and Invalid literal int error) (#3727)
  Add dir attribute to the html tag, ltr/rtl. (#3728)
  docs: remove duplicate info at references > workflows (#3730)
  Updated PR template to reflect testing practices (#3729)
theskumar added a commit that referenced this pull request Jan 29, 2024
…-html

* maintainance/svg-updates:
  Remove public "partners" app
  Remove public primary nav (db) and "news" app (#3715)
  Fix errors for compare revisions page(JSONDecodeError and Invalid literal int error) (#3727)
  Add dir attribute to the html tag, ltr/rtl. (#3728)
  docs: remove duplicate info at references > workflows (#3730)
  Updated PR template to reflect testing practices (#3729)

# Conflicts:
#	hypha/templates/base-apply.html
#	hypha/templates/base.html
wes-otf added a commit that referenced this pull request May 7, 2024
Quick PR to update the PR template reflecting the testing conversations
we had today
wes-otf added a commit that referenced this pull request May 8, 2024
Quick PR to update the PR template reflecting the testing conversations
we had today
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Maintenance Type: Patch Mini change, used in release drafter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants