Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove public primary nav (db) and "news" app #3715

Merged
merged 3 commits into from
Jan 29, 2024
Merged

Remove public primary nav (db) and "news" app #3715

merged 3 commits into from
Jan 29, 2024

Conversation

theskumar
Copy link
Member

@theskumar theskumar commented Jan 10, 2024 •
edited
Loading

  • Removes the NavigationSettings and it's template tag. Keeps the custom html based navigation
  • Keeps the "news" installed app, so that model migrations are applied
  • update the sandbox db to remove news page data and schema from it
  • Remove management command for public pages exports

@theskumar theskumar self-assigned this Jan 10, 2024
@theskumar theskumar requested review from frjo and wes-otf January 10, 2024 07:28
@theskumar theskumar marked this pull request as ready for review January 10, 2024 07:29
@theskumar
Remove public news module
9afb76a 
- Keeps the "news" installed app, so that model migrations are applied
- update the sandbox db to remove news page data from it
@theskumar theskumar force-pushed the maintainance/remove-public-news branch 2 times, most recently from 19362f7 to 1c5ee27 Compare January 10, 2024 07:53
@theskumar theskumar changed the title Remove public news module Remove public primary nav (db) and news module Jan 10, 2024
@theskumar theskumar force-pushed the maintainance/remove-public-news branch from 1c5ee27 to ada7196 Compare January 10, 2024 07:58
@theskumar theskumar mentioned this pull request Jan 10, 2024
Merged
@theskumar theskumar changed the title Remove public primary nav (db) and news module Remove public primary nav (db) and "news" app Jan 10, 2024
@frjo frjo added Type: Maintenance Type: Minor Minor change, used in release drafter labels Jan 10, 2024
@frjo frjo added the Status: Needs testing Tickets that need testing/qa label Jan 15, 2024
@theskumar
Merge branch 'main' into maintainance/remove-public-news
03e0e08 
* main:
  Remove public "search promotions" app (#3724)
  docs: update fetch-depth=0 and update copyright year (#3723)
  Restyle the status bar (#3672)
  Replace black with ruff formatter (#3688)
@wes-otf wes-otf added Status: Needs dev testing 🧑‍💻 Tasks that should be tested by the dev team and removed Status: Needs testing Tickets that need testing/qa labels Jan 24, 2024
@frjo frjo merged commit d63620b into main Jan 29, 2024
theskumar added a commit that referenced this pull request Jan 29, 2024
@theskumar
Merge branch 'main' into maintainance/remove-public-news
16046cf 
* main:
  Remove public primary nav (db) and "news" app (#3715)
  Fix errors for compare revisions page(JSONDecodeError and Invalid literal int error) (#3727)
  Add dir attribute to the html tag, ltr/rtl. (#3728)
  docs: remove duplicate info at references > workflows (#3730)
  Updated PR template to reflect testing practices (#3729)
theskumar added a commit that referenced this pull request Jan 29, 2024
@theskumar
Merge remote-tracking branch 'origin/maintainance/remove-partners-app…
06a87ab 
…' into maintainance/remove-partners-app

* origin/maintainance/remove-partners-app:
  Remove public "partners" app
  Remove public primary nav (db) and "news" app (#3715)
  Fix errors for compare revisions page(JSONDecodeError and Invalid literal int error) (#3727)
  Add dir attribute to the html tag, ltr/rtl. (#3728)
  docs: remove duplicate info at references > workflows (#3730)
  Updated PR template to reflect testing practices (#3729)
theskumar added a commit that referenced this pull request Jan 29, 2024
@theskumar
Merge branch 'maintainance/remove-partners-app' into maintainance/3-r…
3ec1e0a 
…emove-people-app

* maintainance/remove-partners-app:
  Remove public "partners" app
  Remove public primary nav (db) and "news" app (#3715)
  Fix errors for compare revisions page(JSONDecodeError and Invalid literal int error) (#3727)
  Add dir attribute to the html tag, ltr/rtl. (#3728)
  docs: remove duplicate info at references > workflows (#3730)
  Updated PR template to reflect testing practices (#3729)
theskumar added a commit that referenced this pull request Jan 29, 2024
@theskumar
Merge branch 'maintainance/3-remove-people-app' into maintainance/4-r…
2c964e5 
…emove-projects-app

* maintainance/3-remove-people-app:
  Remove public "partners" app
  Remove public primary nav (db) and "news" app (#3715)
  Fix errors for compare revisions page(JSONDecodeError and Invalid literal int error) (#3727)
  Add dir attribute to the html tag, ltr/rtl. (#3728)
  docs: remove duplicate info at references > workflows (#3730)
  Updated PR template to reflect testing practices (#3729)
theskumar added a commit that referenced this pull request Jan 29, 2024
@theskumar
Merge branch 'maintainance/4-remove-projects-app' into maintainance/5…
dbc49bb 
…-remove-public-forms-app

* maintainance/4-remove-projects-app:
  Remove public "partners" app
  Remove public primary nav (db) and "news" app (#3715)
  Fix errors for compare revisions page(JSONDecodeError and Invalid literal int error) (#3727)
  Add dir attribute to the html tag, ltr/rtl. (#3728)
  docs: remove duplicate info at references > workflows (#3730)
  Updated PR template to reflect testing practices (#3729)
theskumar added a commit that referenced this pull request Jan 29, 2024
@theskumar
Merge branch 'maintainance/5-remove-public-forms-app' into maintainan…
a40932a 
…ce/6-remove-public-lab-round-page

* maintainance/5-remove-public-forms-app:
  Remove public "partners" app
  Remove public primary nav (db) and "news" app (#3715)
  Fix errors for compare revisions page(JSONDecodeError and Invalid literal int error) (#3727)
  Add dir attribute to the html tag, ltr/rtl. (#3728)
  docs: remove duplicate info at references > workflows (#3730)
  Updated PR template to reflect testing practices (#3729)
theskumar added a commit that referenced this pull request Jan 29, 2024
@theskumar
Merge branch 'maintainance/6-remove-public-lab-round-page' into maint…
45e6609 
…ainance/7-remove-standard-pages

* maintainance/6-remove-public-lab-round-page:
  Remove public "partners" app
  Remove public primary nav (db) and "news" app (#3715)
  Fix errors for compare revisions page(JSONDecodeError and Invalid literal int error) (#3727)
  Add dir attribute to the html tag, ltr/rtl. (#3728)
  docs: remove duplicate info at references > workflows (#3730)
  Updated PR template to reflect testing practices (#3729)
theskumar added a commit that referenced this pull request Jan 29, 2024
@theskumar
Merge branch 'maintainance/7-remove-standard-pages' into maintainance…
a31b2f4 
…/8-cookie-settings

* maintainance/7-remove-standard-pages:
  Remove public "partners" app
  Remove public primary nav (db) and "news" app (#3715)
  Fix errors for compare revisions page(JSONDecodeError and Invalid literal int error) (#3727)
  Add dir attribute to the html tag, ltr/rtl. (#3728)
  docs: remove duplicate info at references > workflows (#3730)
  Updated PR template to reflect testing practices (#3729)
theskumar added a commit that referenced this pull request Jan 29, 2024
@theskumar
Merge branch 'maintainance/8-cookie-settings' into maintainance/svg-u…
a3b270c 
…pdates

* maintainance/8-cookie-settings:
  Remove public "partners" app
  Remove public primary nav (db) and "news" app (#3715)
  Fix errors for compare revisions page(JSONDecodeError and Invalid literal int error) (#3727)
  Add dir attribute to the html tag, ltr/rtl. (#3728)
  docs: remove duplicate info at references > workflows (#3730)
  Updated PR template to reflect testing practices (#3729)
theskumar added a commit that referenced this pull request Jan 29, 2024
@theskumar
Merge branch 'maintainance/svg-updates' into maintainance/public-base…
4e105bb 
…-html

* maintainance/svg-updates:
  Remove public "partners" app
  Remove public primary nav (db) and "news" app (#3715)
  Fix errors for compare revisions page(JSONDecodeError and Invalid literal int error) (#3727)
  Add dir attribute to the html tag, ltr/rtl. (#3728)
  docs: remove duplicate info at references > workflows (#3730)
  Updated PR template to reflect testing practices (#3729)

# Conflicts:
#	hypha/templates/base-apply.html
#	hypha/templates/base.html
frjo pushed a commit that referenced this pull request Jan 29, 2024
@theskumar
Remove public "partners" app (#3716)
1f9aa29 
- Keep the app installed so the delete table migrations could run
- Update sandbox-db with removed tables

Depends on #3715
wes-otf pushed a commit that referenced this pull request May 7, 2024
@theskumar @wes-otf
Remove public primary nav (db) and "news" app (#3715)
1c144d1 
- Removes the `NavigationSettings` and it's template tag. Keeps the
custom html based navigation
- Keeps the "news" installed app, so that model migrations are applied
- update the sandbox db to remove news page data and schema from it
- Remove management command for public pages exports
wes-otf pushed a commit that referenced this pull request May 7, 2024
@theskumar @wes-otf
Remove public "partners" app (#3716)
1696130 
- Keep the app installed so the delete table migrations could run
- Update sandbox-db with removed tables

Depends on #3715
wes-otf pushed a commit that referenced this pull request May 8, 2024
@theskumar @wes-otf
Remove public primary nav (db) and "news" app (#3715)
52fa76a 
- Removes the `NavigationSettings` and it's template tag. Keeps the
custom html based navigation
- Keeps the "news" installed app, so that model migrations are applied
- update the sandbox db to remove news page data and schema from it
- Remove management command for public pages exports
wes-otf pushed a commit that referenced this pull request May 8, 2024
@theskumar @wes-otf
Remove public "partners" app (#3716)
e8ecef7 
- Keep the app installed so the delete table migrations could run
- Update sandbox-db with removed tables

Depends on #3715
Vldln pushed a commit to equalitie/hypha that referenced this pull request May 28, 2024
@theskumar
Remove public primary nav (db) and "news" app (HyphaApp#3715)
4e5ff29 
- Removes the `NavigationSettings` and it's template tag. Keeps the
custom html based navigation
- Keeps the "news" installed app, so that model migrations are applied
- update the sandbox db to remove news page data and schema from it
- Remove management command for public pages exports
Vldln pushed a commit to equalitie/hypha that referenced this pull request May 28, 2024
@theskumar
Remove public "partners" app (HyphaApp#3716)
fbbaece 
- Keep the app installed so the delete table migrations could run
- Update sandbox-db with removed tables

Depends on HyphaApp#3715
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frjo frjo frjo approved these changes

@wes-otf wes-otf wes-otf approved these changes

Assignees

@theskumar theskumar

Labels
Status: Needs dev testing 🧑‍💻 Tasks that should be tested by the dev team Type: Maintenance Type: Minor Minor change, used in release drafter
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@theskumar @frjo @wes-otf