-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/bulkprocessor #564
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
669c157
Bulk processor
michaelsoubra 0a2dde3
fix bugs null pointer
michaelsoubra 637d876
merge
michaelsoubra 02ace5d
Merge branch 'release/v1.4.0' of https://github.com/Hurence/logisland…
michaelsoubra b320cac
bulk processor threshold
michaelsoubra 60a36a4
Comments fixing
michaelsoubra File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
123 changes: 123 additions & 0 deletions
123
...c/main/java/com/hurence/logisland/rest/processor/lookup/AsyncCallRequestBulkPostJson.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,123 @@ | ||
/** | ||
* Copyright (C) 2016 Hurence ([email protected]) | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
package com.hurence.logisland.rest.processor.lookup; | ||
|
||
|
||
import com.hurence.logisland.annotation.documentation.CapabilityDescription; | ||
import com.hurence.logisland.annotation.documentation.Tags; | ||
import com.hurence.logisland.component.InitializationException; | ||
import com.hurence.logisland.error.ErrorUtils; | ||
import com.hurence.logisland.processor.ProcessContext; | ||
import com.hurence.logisland.processor.ProcessError; | ||
import com.hurence.logisland.record.Record; | ||
import com.hurence.logisland.record.StandardRecord; | ||
import io.reactivex.Maybe; | ||
import io.vertx.core.Handler; | ||
import io.vertx.reactivex.core.Promise; | ||
import io.vertx.reactivex.core.Vertx; | ||
|
||
import java.io.ByteArrayOutputStream; | ||
import java.io.OutputStream; | ||
import java.lang.reflect.Array; | ||
import java.util.ArrayList; | ||
import java.util.Collection; | ||
import java.util.List; | ||
import java.util.Optional; | ||
import java.util.stream.Collectors; | ||
|
||
@Tags({"rest", "record", "http", "request", "call", "server"}) | ||
@CapabilityDescription("Execute an http request with specified verb, body and mime type. Then stock result as a Record in the specified field") | ||
//@ExtraDetailFile("./details/common-processors/BulkPut-Detail.rst") | ||
public class AsyncCallRequestBulkPostJson extends AbstractCallRequest | ||
{ | ||
private Vertx vertx; | ||
|
||
@Override | ||
public void init(ProcessContext context) throws InitializationException { | ||
super.init(context); | ||
try { | ||
vertx = Vertx.vertx(); | ||
} catch (Exception ex) { | ||
throw new InitializationException(ex); | ||
} | ||
} | ||
|
||
public void stop() { | ||
if (vertx != null) { | ||
vertx.close(); | ||
} | ||
} | ||
|
||
/** | ||
* process events | ||
* | ||
* @param context | ||
* @param records | ||
* @return | ||
*/ | ||
@Override | ||
public Collection<Record> process(final ProcessContext context, final Collection<Record> records) { | ||
if (records.isEmpty()) { | ||
getLogger().warn("process has been called with an empty list of records !"); | ||
return records; | ||
} | ||
/** | ||
* loop over events to add them to bulk | ||
*/ | ||
getLogger().debug("Into the bulk " ); | ||
|
||
ArrayList<Optional<String>> requestBodies = concatBody(records, context); | ||
getLogger().debug("Bulk body " +requestBodies ); | ||
|
||
if ( requestBodies !=null && !requestBodies.isEmpty() && records.stream().findFirst().isPresent()) { | ||
for (Optional<String> bodies : requestBodies) { | ||
if (bodies.isPresent()) { | ||
Record record = records.stream().findFirst().get(); | ||
StandardRecord coordinates = new StandardRecord(record); | ||
|
||
calculVerb(record, context).ifPresent(verb -> coordinates.setStringField(restClientService.getMethodKey(), verb)); | ||
calculMimTyp(record, context).ifPresent(mimeType -> coordinates.setStringField(restClientService.getMimeTypeKey(), mimeType)); | ||
|
||
coordinates.setStringField(restClientService.getbodyKey(), bodies.get()); | ||
|
||
getLogger().debug("Calling bulk for method " + coordinates.getField(restClientService.getMethodKey()).asString() + | ||
" type " + coordinates.getField(restClientService.getMimeTypeKey()).asString() + | ||
" with body " + coordinates.getField(restClientService.getbodyKey()).asString()); | ||
Handler<Promise<Optional<Record>>> callRequestHandler = p -> { | ||
try { | ||
p.complete(restClientService.lookup(coordinates)); | ||
} catch (Throwable t) { //There is other errors than LookupException, The proxyWrapper does wrap those into Reflection exceptions... | ||
p.fail(t); | ||
} | ||
}; | ||
|
||
Maybe<Optional<Record>> response = vertx | ||
.rxExecuteBlocking(callRequestHandler) | ||
.doOnError(t -> { | ||
ErrorUtils.handleError(getLogger(), t, record, ProcessError.RUNTIME_ERROR.getName()); | ||
}) | ||
.doOnSuccess(rspOpt -> { | ||
rspOpt.ifPresent(rsp -> modifyRecord(record, rsp)); | ||
}); | ||
response.blockingGet();// wait until the request is done | ||
} | ||
} | ||
} | ||
getLogger().debug("Bulk ended " ); | ||
stop(); | ||
return records; | ||
} | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This method does not seem general to me. I mean it is usefull only for a specific case so I wonder why it is in AbstractCallRequest. And this method is currently used only in one processor so there is no reason to have this method in AbstractCallRequest (which should really be general)