Feature/bulkprocessor #564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MiniPlayer
reviewed
Dec 17, 2020
| if the record contains one of the tag of the property with one of the value for this tag it will return true | ||
| */ | ||
| Boolean triggerRestCall(Record record, ProcessContext context) { | ||
| List<Boolean> resultContainer = new ArrayList<>(); |
There was a problem hiding this comment.
Why using a list of boolean ? We could just return true as soon as a tag match
| @@ -213,6 +237,62 @@ void modifyRecord(Record record, Record rsp) { | |||
| return Optional.empty(); | |||
| } | |||
|
|
|||
| ArrayList<Optional<String>> concatBody(Collection<Record> records, ProcessContext context) { | |||
There was a problem hiding this comment.
This method does not seem general to me. I mean it is usefull only for a specific case so I wonder why it is in AbstractCallRequest. And this method is currently used only in one processor so there is no reason to have this method in AbstractCallRequest (which should really be general)
Comment on lines
+433
to
+434
| <arg>-Xmax-classfile-name</arg> | ||
| <arg>140</arg> |
There was a problem hiding this comment.
Maybe a comment explaining why this is needed would have been nice
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.