-
-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
prefix function #752
prefix function #752
Conversation
🦋 Changeset detectedLatest commit: 293c790 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Just a quick comment. Wouldn't this effect/fix #597? Having the type without the _ prefix prevents the collision. |
Yes, you are right. We will have no more collisions with this fix. You will be able to do: import { FooVariables } from '$houdini'
export const _FooVariables: FooVariables = () => { ...} Just FYI, I will probably continue to use: import { FooVariables as V } from '$houdini'
export const _FooVariables: V = () => { ...} To have as less "FooVariables" as possible, but I guess that it's only a preference |
* ♻️ UPDATE: e2e to use _ for houdini functions * ✨ UPDATE: with _ * ⬆️ UPDATE: version * ✏️ UPDATE: update doc (HoudiniGraphql#751) * 💡 UPDATE: no french * 👌 FIX: linting * 👌 FIX: linting (v2) * ✅ UPDATE: tests * ✏️ UPDATE: changeset * ✅ UPDATE: tests
* ♻️ UPDATE: e2e to use _ for houdini functions * ✨ UPDATE: with _ * ⬆️ UPDATE: version * ✏️ UPDATE: update doc (HoudiniGraphql#751) * 💡 UPDATE: no french * 👌 FIX: linting * 👌 FIX: linting (v2) * ✅ UPDATE: tests * ✏️ UPDATE: changeset * ✅ UPDATE: tests
Fixes #751, closes #597
Since SvelteKit
1.0.0-next.573
, we are not allowed to export non-Kit functions from+page.js
, or it has to start with "_
".To help everyone out, please make sure your PR does the following:
pnpm run tests
andcd integration && pnpm run tests
pnpm changeset