Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invalid export 'houdini_load' #751

Closed
pixelmund opened this issue Dec 9, 2022 · 1 comment · Fixed by #752
Closed

Invalid export 'houdini_load' #751

pixelmund opened this issue Dec 9, 2022 · 1 comment · Fixed by #752

Comments

@pixelmund
Copy link
Contributor

pixelmund commented Dec 9, 2022 •
edited
Loading

Describe the bug

I tried to play around with the example and i think one of the last SvelteKit changes broke houdini.
Kit now disallows any non kit exports from +page.js

Invalid export 'houdini_load' in src/routes/[filter]/+page.ts (valid exports are load, prerender, csr, ssr, trailingSlash, or anything with a '_' prefix)

Severity

blocking all usage of Houdini

Steps to Reproduce the Bug

  1. Clone the reproduction
  2. Run pnpm api
  3. Run pnpm dev
  4. View the error in the console

Reproduction

https://github.com/pixelmund/houdini-invalid-export-repro
@pixelmund pixelmund mentioned this issue Dec 9, 2022
Closed
@jycouet
Copy link
Contributor

jycouet commented Dec 9, 2022

Thank you for reporting this @pixelmund

Yes, it's the consequence of sveltejs/kit#7845 (comment)
For now, the latest SvelteKit version working with Houdini is 1.0.0-next.572.

Kit is moving at a fast pace with it's 5️⃣ remaining issues to 1.0 🥳🥳🥳
Let's keep the momentum, I'll look into this right now.

jycouet added a commit that referenced this issue Dec 9, 2022
@jycouet
✏️ UPDATE: update doc (#751)
81de99b
@jycouet jycouet mentioned this issue Dec 9, 2022
Merged
5 tasks
AlecAivazis pushed a commit that referenced this issue Dec 13, 2022
@jycouet
Add _ prefix to magic exports (#752)
d1fcc47 
* ♻️ UPDATE: e2e to use _ for houdini functions

* ✨ UPDATE: with _

* ⬆️ UPDATE: version

* ✏️ UPDATE: update doc (#751)

* 💡 UPDATE: no french

* 👌 FIX: linting

* 👌 FIX: linting (v2)

* ✅ UPDATE: tests

* ✏️ UPDATE: changeset

* ✅ UPDATE: tests
gterras pushed a commit to gterras/houdini that referenced this issue Dec 14, 2022
@jycouet
Add _ prefix to magic exports (HoudiniGraphql#752)
606c8f1 
* ♻️ UPDATE: e2e to use _ for houdini functions

* ✨ UPDATE: with _

* ⬆️ UPDATE: version

* ✏️ UPDATE: update doc (HoudiniGraphql#751)

* 💡 UPDATE: no french

* 👌 FIX: linting

* 👌 FIX: linting (v2)

* ✅ UPDATE: tests

* ✏️ UPDATE: changeset

* ✅ UPDATE: tests
endigma pushed a commit to endigma/houdini that referenced this issue Nov 10, 2024
@jycouet @endigma
Add _ prefix to magic exports (HoudiniGraphql#752)
9cbadb5 
* ♻️ UPDATE: e2e to use _ for houdini functions

* ✨ UPDATE: with _

* ⬆️ UPDATE: version

* ✏️ UPDATE: update doc (HoudiniGraphql#751)

* 💡 UPDATE: no french

* 👌 FIX: linting

* 👌 FIX: linting (v2)

* ✅ UPDATE: tests

* ✏️ UPDATE: changeset

* ✅ UPDATE: tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

prefix function HoudiniGraphql/houdini
2 participants
@jycouet @pixelmund