Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libphonenumber 8.12.46 #98994

Closed

Conversation

chenrui333
Copy link
Member

Created with brew bump-formula-pr.

@BrewTestBot BrewTestBot added the bump-formula-pr PR was created using `brew bump-formula-pr` label Apr 10, 2022
@chenrui333
Copy link
Member Author

/home/linuxbrew/.linuxbrew/opt/libphonenumber/include/phonenumbers/phonenumberutil.h:33:42: fatal error: absl/container/node_hash_set.h: No such file or directory

@chenrui333 chenrui333 added test failure CI fails while running the test-do block CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. labels Apr 10, 2022
@cho-m
Copy link
Member

cho-m commented Apr 12, 2022

Sounds like it is using abseil, though odd the build passed without it if it is a requirement. Since abseil headers are being included, they also need to be available during test in order to use libphonenumber headers.


Upstream may be downloading/building a local copy of abseil:
https://github.com/google/libphonenumber/blob/v8.12.46/tools/cpp/CMakeLists.txt#L31-L36

May want to avoid that similar to ArchLinux https://github.com/archlinux/svntogit-packages/blob/packages/libphonenumber/trunk/absl.diff

@github-actions
Copy link
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. To keep this pull request open, add a help wanted or in progress label.

@github-actions github-actions bot added the stale No recent activity label Apr 14, 2022
@github-actions github-actions bot closed this Apr 16, 2022
@github-actions github-actions bot added the outdated PR was locked due to age label May 16, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 16, 2022
@chenrui333
Copy link
Member Author

Sounds like it is using abseil, though odd the build passed without it if it is a requirement. Since abseil headers are being included, they also need to be available during test in order to use libphonenumber headers.

Upstream may be downloading/building a local copy of abseil: https://github.com/google/libphonenumber/blob/v8.12.46/tools/cpp/CMakeLists.txt#L31-L36

May want to avoid that similar to ArchLinux https://github.com/archlinux/svntogit-packages/blob/packages/libphonenumber/trunk/absl.diff

applied the patch in this PR, #101703

@chenrui333 chenrui333 added the superseded PR was replaced by another PR label May 16, 2022
@chenrui333 chenrui333 deleted the bump-libphonenumber-8.12.46 branch December 18, 2022 06:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bump-formula-pr PR was created using `brew bump-formula-pr` CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. outdated PR was locked due to age stale No recent activity superseded PR was replaced by another PR test failure CI fails while running the test-do block
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants