libphonenumber 8.12.48 #101703
Closed
libphonenumber 8.12.48 #101703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chenrui333
added
the
CI-no-fail-fast
Signed-off-by: Rui Chen <[email protected]> update build Signed-off-by: Rui Chen <[email protected]>
chenrui333
force-pushed
the
bump-libphonenumber-8.12.48
branch
from
dd642c1 to
29f0414
Compare
Signed-off-by: Rui Chen <[email protected]>
|
Can you also submit that fix upstream? |
Submitted a build improvement in the upstream, #101703 |
|
Can you make a reference to that PR in a comment? |
|
any blocker of merging this? cc @SMillerDev |
|
Why not use the upstream PR as the patch? |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
6 tasks
carlocab
added a commit
to carlocab/homebrew-core
that referenced
this pull request
Jul 14, 2022
This downloads its own `abseil` during the build, and then gets confused about where to find `abseil` headers when you try to link with it. Let's fix that by relying on our version of `abseil` instead. This should help unblock Homebrew#105712 and previous attempts to bump this formula's version (e.g. Homebrew#105188, Homebrew#101703, Homebrew#98994, Homebrew#96834).
BrewTestBot
pushed a commit
that referenced
this pull request
Jul 14, 2022
This downloads its own `abseil` during the build, and then gets confused about where to find `abseil` headers when you try to link with it. Let's fix that by relying on our version of `abseil` instead. This should help unblock #105712 and previous attempts to bump this formula's version (e.g. #105188, #101703, #98994, #96834). Closes #105800. Signed-off-by: BrewTestBot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew install --build-from-source <formula>, where<formula>is the name of the formula you're submitting?brew test <formula>, where<formula>is the name of the formula you're submitting?brew audit --strict <formula>(after doingbrew install --build-from-source <formula>)? If this is a new formula, does it passbrew audit --new <formula>?