bat: install bundled fish completions #40280
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lwolfsonkin
changed the title
bat](https://github.com/sharkdp/bat). In bat version [v0.11.0](https://github.com/sharkdp/bat/releases/tag/v0.11.0), they added [manually written](https://github.com/sharkdp/bat/pull/524) [fish completions](https://github.com/sharkdp/bat/pull/555) since they disabled the automatically generated completions in [v0.10.0](https://github.com/sharkdp/bat/releases/tag/v0.10.0). This update simply installs them during brew install.bat to install bundled fish completions
lwolfsonkin
changed the title
bat to install bundled fish completions
lwolfsonkin
changed the title
zbeekman
suggested changes
May 25, 2019
|
Revision bumped! Thanks for the review, @zbeekman! |
|
@lwolfsonkin For future reference: Please set the commit message to start with the formula name (like the PR title) and squash commits. Thanks! |
|
Thanks for your contribution to Homebrew! 🎉 🥇 Without awesome contributors like you, it would be impossible to maintain Homebrew to the high level of quality users have come to expect. Thank you!!!! |
zbeekman
pushed a commit
that referenced
this pull request
May 25, 2019
Closes #40280. Signed-off-by: Izaak Beekman <[email protected]>
|
Will squash for the future! Sorry about that. And no problem! :) |
zgracem
added a commit
to zgracem/dotconfig
that referenced
this pull request
Jun 4, 2019
These are included w/ installation as of Homebrew/homebrew-core#40280
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Installs bundled fish completions for
bat.In
batversion v0.11.0, they added manually written fish completions (in sharkdp/bat#524 and sharkdp/bat#555) since they disabled the automatically generated completions in v0.10.0. This update simply installs them duringbrew install. Note that this is a sort of soft reversion of #36116.brew install --build-from-source <formula>, where<formula>is the name of the formula you're submitting?brew test <formula>, where<formula>is the name of the formula you're submitting?brew audit --strict <formula>(after doingbrew install <formula>)?brew auditlike in freetds 1.00.15 #5561, so I could not. I attempted troubleshooting, but to no avail.