Bat formula ships outdated fish completions

[ohcibi]

See sharkdp/bat#372

Bat has removed its fish completions but this formula does install broken ones.

[fxcoudert]

In bat version 0.9.0, completion files are built during the bat build process (see build.rs). We are installing them because they are produced.

A pull request not to install them would be welcome. But this would be better decided upstream: if the completions are not supported, they should simply not be produced.

[ohcibi]

@fxcoudert This has already been decided upstream. See the linked issues. The one piece thats missing is this formula. The files are generated but they are not intended to be shipped automatically.

I would make sourcing those files optional for users of this formula. If I just remove the install........fish line, all generated files that are not "installed" will be removed on the next brew cleanup is that correct?

[fxcoudert]

I have read the upstream issue, and the relevant commit sharkdp/bat#391 which only affects CI. This is, according to upstream, “temporary”. So clarification on the status would be welcome.

As I said, a pull request not to install the completion files is welcome.