Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

autobump: remove kiota #183622

Merged
merged 1 commit into from
Sep 5, 2024
Merged

autobump: remove kiota #183622

merged 1 commit into from
Sep 5, 2024

Conversation

chenrui333
Copy link
Member

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

https://github.com/Homebrew/homebrew-core/pulls?q=is%3Apr+kiota

Signed-off-by: Rui Chen <[email protected]>
@chenrui333 chenrui333 added CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. autobump labels Sep 5, 2024
@chenrui333 chenrui333 mentioned this pull request Sep 5, 2024
@github-actions github-actions bot added the automerge-skip `brew pr-automerge` will skip this pull request label Sep 5, 2024
@Homebrew Homebrew deleted a comment from github-actions bot Sep 5, 2024
@chenrui333 chenrui333 removed the automerge-skip `brew pr-automerge` will skip this pull request label Sep 5, 2024
@BrewTestBot BrewTestBot added this pull request to the merge queue Sep 5, 2024
Merged via the queue into master with commit 7caf182 Sep 5, 2024
19 checks passed
@BrewTestBot BrewTestBot deleted the kiota-autobump branch September 5, 2024 19:29
@baywet
Copy link
Contributor

baywet commented Sep 6, 2024

Hi @chenrui333 @stefanb 👋
Vincent from the Kiota team here. Apologies if I'm asking naïve questions, I have little MacOS experience and zero experience with homebrew.

The reason why the autobump is failing is because kiota is a little "ahead" of the dotnet formula here in terms of dependencies.
Merging #173089 would likely unblock the kiota formula for v1.18.0
In the meantime, an upgrade to kiota v1.13.0 should be aligned with dotnet v8.0.4 (version currently published on homebrew) and be beneficial to kiota + homebrew users.

Before I proceed with a potential PR for the kiota formula, I thought I'd reach out to see which direction you'd like to take.

@baywet
Copy link
Contributor

baywet commented Sep 6, 2024

Put together #183725 to test my theory

@baywet
Copy link
Contributor

baywet commented Sep 6, 2024

Put together #183725 to test my theory

Which didn't work because of misalignment of versions still.

Put together this on kiota's side.
microsoft/kiota#5356
and #183727

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autobump CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants