-
-
Notifications
You must be signed in to change notification settings - Fork 12.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "autobump: remove kiota" #183727
Revert "autobump: remove kiota" #183727
Conversation
This reverts commit 5f2a322.
@baywet thanks for the pr, can you bump kiota to the latest release as well? Thanks! |
@chenrui333 I was wondering whether you would want that to be in the same or a separate PR. |
you can do in the same PR, that is fine. (also squash the commits) |
Unmerged upstream PR could be also used to patch official releases until that upstream PR is released. |
How? |
Tried with patching in #183911, but it still gives (the same?) error... |
@stefanb That's because even though microsoft/kiota#5356 has been merged, it hasn't been released yet. So unless we can define the Formula to use a commit hash instead of a tag, we'll have to wait before we can create a new version here. That's why I submitted this PR as draft initially. |
i guess we can close it for now, and file a new one once the patch is being released. what do you think @baywet. |
Can we keep it until the patch is out? Supposed to go out on Friday |
@baywet any update on the thread? Thanks! |
Patch has been cancelled as far as I can tell. Which puts us on the next minor on Oct 4th. I have a task to remind me to follow up here once a new version is out. |
@chenrui333 As promised, here is a test PR for a one time upgrade. #193091 |
np, maybe we can just merge the two? wdyt? |
sure, if you're happy with the change. My other PR is failing CI at the moment for a different (new) reason though, would you mind hoping over there and giving me pointers please? |
merge this into #193091 |
restores kiota auto-bump, depends on microsoft/kiota#5356 to be merged and released