-
-
Notifications
You must be signed in to change notification settings - Fork 12.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
euler-py: vendor deps #163143
euler-py: vendor deps #163143
Conversation
sha256 "ca9853ad459e787e2192211578cc907e7594e294c7ccc834310722b41b9ca6de" | ||
end | ||
|
||
resource "setuptools" do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is setuptools
still required as an explicit resource? Asking because my understanding is that pip will attempt to download it if it's unavailable.
Wondering if (in general) setuptools
makes sense to be included as an explicit resource if it is for some reason a runtime dependency?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is
setuptools
still required as an explicit resource? Asking because my understanding is that pip will attempt to download it if it's unavailable.
euler-py
is too old (2019-12-13) that it is still using deprecated setup.py
which assumes that setuptools
/distutils
is bundled with Python (no longer the case with 3.12).
In order for build-time setuptools
to be automatically installed, projects usually need to use pyproject.toml
instead and have:
[build-system]
requires = ["setuptools"]
Wondering if (in general)
setuptools
makes sense to be included as an explicit resource if it is for some reason a runtime dependency?
Usually, we want to only have runtime dependencies in resource list (i.e. the packages that show up when running brew update-python-resources <formula>
).
However, setuptools
is a bit of an odd one given it used to be bundled in Python 3.11 and older. So, a lot of Python packages assume it exists.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've been forcing pip
to behave as if there was a pyproject.toml
with --use-pep517
(which will eventually become the default), e.g.
ENV["PIP_USE_PEP517"] = "1"
🤖 An automated task has requested bottles to be published to this PR. |
HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>
, where<formula>
is the name of the formula you're submitting?brew test <formula>
, where<formula>
is the name of the formula you're submitting?brew audit --strict <formula>
(after doingHOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>
)? If this is a new formula, does it passbrew audit --new <formula>
?