Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

euler-py: vendor deps #163143

Merged
merged 2 commits into from
Feb 18, 2024
Merged

euler-py: vendor deps #163143

merged 2 commits into from
Feb 18, 2024

Conversation

iMichka
Copy link
Member

@iMichka iMichka commented Feb 18, 2024

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@iMichka iMichka added the python-vendoring Part of the Python resource vendoring project label Feb 18, 2024
@github-actions github-actions bot added the automerge-skip `brew pr-automerge` will skip this pull request label Feb 18, 2024
sha256 "ca9853ad459e787e2192211578cc907e7594e294c7ccc834310722b41b9ca6de"
end

resource "setuptools" do
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is setuptools still required as an explicit resource? Asking because my understanding is that pip will attempt to download it if it's unavailable.

Wondering if (in general) setuptools makes sense to be included as an explicit resource if it is for some reason a runtime dependency?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is setuptools still required as an explicit resource? Asking because my understanding is that pip will attempt to download it if it's unavailable.

euler-py is too old (2019-12-13) that it is still using deprecated setup.py which assumes that setuptools/distutils is bundled with Python (no longer the case with 3.12).

In order for build-time setuptools to be automatically installed, projects usually need to use pyproject.toml instead and have:

[build-system]
requires = ["setuptools"]

Wondering if (in general) setuptools makes sense to be included as an explicit resource if it is for some reason a runtime dependency?

Usually, we want to only have runtime dependencies in resource list (i.e. the packages that show up when running brew update-python-resources <formula>).

However, setuptools is a bit of an odd one given it used to be bundled in Python 3.11 and older. So, a lot of Python packages assume it exists.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've been forcing pip to behave as if there was a pyproject.toml with --use-pep517 (which will eventually become the default), e.g.

ENV["PIP_USE_PEP517"] = "1"

@p-linnane p-linnane removed the automerge-skip `brew pr-automerge` will skip this pull request label Feb 18, 2024
Copy link
Contributor

🤖 An automated task has requested bottles to be published to this PR.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Feb 18, 2024
@BrewTestBot BrewTestBot added this pull request to the merge queue Feb 18, 2024
Merged via the queue into Homebrew:master with commit 8ec271b Feb 18, 2024
12 checks passed
@iMichka iMichka deleted the euler-py branch February 19, 2024 22:20
This was referenced Mar 5, 2024
@github-actions github-actions bot added the outdated PR was locked due to age label Mar 21, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. outdated PR was locked due to age python-vendoring Part of the Python resource vendoring project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants