Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fonttools: vendor deps #165104

Merged
merged 2 commits into from
Mar 11, 2024
Merged

fonttools: vendor deps #165104

merged 2 commits into from
Mar 11, 2024

Conversation

fxcoudert
Copy link
Member

My first PR on this vendoring project, so I welcome extra-careful review and guidance.

@fxcoudert fxcoudert added the python-vendoring Part of the Python resource vendoring project label Mar 5, 2024
@fxcoudert fxcoudert marked this pull request as ready for review March 5, 2024 15:42
@SMillerDev
Copy link
Member

I'm not super involved in this migration, but I believe we split the vendoring and the removal PRs.

@github-actions github-actions bot added the python Python use is a significant feature of the PR or issue label Mar 5, 2024
@fxcoudert fxcoudert mentioned this pull request Mar 5, 2024
Merged
@fxcoudert
Copy link
Member Author

@SMillerDev This was the only user, but I've split the removal into its own PR: #165112

@github-actions github-actions bot added the automerge-skip `brew pr-automerge` will skip this pull request label Mar 5, 2024
@fxcoudert fxcoudert changed the title Remove python-brotli and vendor it in fonttools fonttools: vendor deps Mar 5, 2024
@chenrui333 chenrui333 removed the automerge-skip `brew pr-automerge` will skip this pull request label Mar 5, 2024
iMichka
iMichka reviewed Mar 5, 2024
View reviewed changes
pypi_formula_mappings.json Outdated Show resolved Hide resolved
@github-actions github-actions bot added the automerge-skip `brew pr-automerge` will skip this pull request label Mar 5, 2024
@branchvincent branchvincent added ready to merge PR can be merged once CI is green and removed automerge-skip `brew pr-automerge` will skip this pull request labels Mar 9, 2024
@github-actions GitHub Actions
Copy link
Contributor

🤖 An automated task has requested bottles to be published to this PR.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Mar 11, 2024
@BrewTestBot BrewTestBot enabled auto-merge March 11, 2024 11:15
@BrewTestBot BrewTestBot added this pull request to the merge queue Mar 11, 2024
Merged via the queue into Homebrew:master with commit c555666 Mar 11, 2024
13 checks passed
@github-actions github-actions bot added the outdated PR was locked due to age label Apr 10, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@iMichka iMichka iMichka left review comments

@branchvincent branchvincent branchvincent left review comments

@bevanjkay bevanjkay bevanjkay approved these changes

@github-actions github-actions[bot] github-actions[bot] approved these changes

Assignees
No one assigned
Labels
CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. outdated PR was locked due to age python Python use is a significant feature of the PR or issue python-vendoring Part of the Python resource vendoring project ready to merge PR can be merged once CI is green
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@fxcoudert @SMillerDev @iMichka @branchvincent @bevanjkay @chenrui333 @BrewTestBot