Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make rotateExtrude operate in radians #299

Merged
merged 3 commits into from
Dec 26, 2020
Merged

Make rotateExtrude operate in radians #299

merged 3 commits into from
Dec 26, 2020

Conversation

isovector
Copy link
Contributor

@isovector isovector commented Nov 20, 2020

Before, rotateExtrude operated over degrees for compatability reasons
with scad. This is an odd choice for the haskell library itself, so
instead we make rotateExtrude do the right thing, and put a shim into
openscad to make the transformation.

Fixes #288

Before, rotateExtrude operated over degrees for compatability reasons
with scad. This is an odd choice for the haskell library itself, so
instead we make rotateExtrude do the right thing, and put a shim into
openscad to make the transformation.
@julialongtin
Copy link
Member

Can we get a test for this?

@isovector
Copy link
Contributor Author

isovector commented Nov 21, 2020 via email

@julialongtin
Copy link
Member

julialongtin commented Nov 21, 2020 via email

@isovector
Copy link
Contributor Author

As far as I can tell, rotateExtrude is hopelessly broken (#307, #308, #309, #310), so I'm not sure these tests will be conclusive.

@julialongtin julialongtin merged commit 5154b31 into Haskell-Things:master Dec 26, 2020
@isovector isovector deleted the rotate-extrude-rads branch December 29, 2020 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RotateExtrude should use radians not degrees
2 participants