You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This is a breaking change, but I think we should change the API to use radians not degrees. Fwiw, I use RotateExtrude to implement a screw, and I calculate a number of rotations anyways and then have to convert to degrees for this function.
This was prompted by #287 (comment). Note that I'm mostly thinking about the Haskell eDSL side, I have no familiarity with ExtOpenScad.
The text was updated successfully, but these errors were encountered:
The reason this uses degrees is that in the scad language, the call to this accepts degrees. in order to change this and maintain openscad compatibility, you would have to put a special case in place.
I've stumbled on this as well and think we should change the Haskell interface but keep the extopenscad one compatible not to break existing code/examples.
Most of ImplicitCAD uses Radians, but the
RotateExtrude
implementation uses degrees:https://github.com/colah/ImplicitCAD/blob/5ddd75006cc8f1d6a0e184f56c3714a9097ce6b0/Graphics/Implicit/ObjectUtil/GetImplicit3.hs#L170-L176
This is a breaking change, but I think we should change the API to use radians not degrees. Fwiw, I use
RotateExtrude
to implement a screw, and I calculate a number of rotations anyways and then have to convert to degrees for this function.This was prompted by #287 (comment). Note that I'm mostly thinking about the Haskell eDSL side, I have no familiarity with ExtOpenScad.
The text was updated successfully, but these errors were encountered: