Remove locations from pool that are not shuffled. #5023
Conversation
|
with this change can we remove then uncomment so we stop unconditionally calling |
|
Good catch, we probably can. |
Done, we still unconditionally call PlaceItemsForType but now that function just doesn't do anything if nothing is actually shuffled. |
|
@serprex if you could go through and hit "resolve conversation" on the comments you made that have been addressed, so there's a bit less visual noise for me to sift through when I check this PR for any new reviews/comments that would be great. |
|
I don't have necessary permissions to resolve my comments. I can delete them if you'd like |
|
Oh, my mistake, I didn't realize that required permissions! We should probably look into that if we want to encourage more reviewers. |
Fixes #4890
Removes locations from the location pool that should not be shuffled, according to the user's chosen settings. For example, if Fairies are not shuffled, previously they were in the pool and had vanilla items placed on them. and would still appear in the spoiler log. Now, they simply never enter the pool, don't need to have vanilla items manually placed on them, and do not appear in the spoiler log.
Part of this change also makes the dungeon location list dynamic, which simplifies the process of adding new locations further. Now, instead of needing to add locations to the respective dungeon location list at compile time, these lists are automatically generated when generating a seed, so all you have to do is put it in the main locationTable, instead of having to both put it there and add the RC to the Dungeons. This resulted in a lot of cleanup in the DungeonInfo classes, with one list that starts out empty instead of like six lists filled with RCs.
Build Artifacts