Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #85

Merged
merged 1 commit into from
Jul 5, 2024
Merged

Update README.md #85

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@

Refer to this article: [Reading a PDF in C# on .NET Core](https://dev.to/eliotjones/reading-a-pdf-in-c-on-net-core-43ef)

The main goal of this POC is to test the available options we have now to read effectively content from PDF files and replace the current [iTextSharp - for .NET Framework](https://www.nuget.org/packages/iTextSharp).
The main goal of this POC is to test the available options for effectively reading content from PDF files and replace the current [iTextSharp—for .NET Framework](https://www.nuget.org/packages/iTextSharp).

---

Comment on lines 22 to 28
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CODE REVIEW

  1. Hyphenation and Grammar: The updated sentence improves clarity and readability by using a proper hyphen and simplifying the structure.

Here's a suggestion to further improve clarity:

-The main goal of this POC is to test the available options we have now to read effectively content from PDF files and replace the current [iTextSharp - for .NET Framework](https://www.nuget.org/packages/iTextSharp).
+The main goal of this POC is to test the available options for effectively reading PDF content and replace the current [iTextSharp—for .NET Framework](https://www.nuget.org/packages/iTextSharp).

This makes the sentence more concise and easier to understand.

Expand All @@ -36,7 +36,7 @@ With the files tested, some errors were detected that could be avoided using som

### ❌ iTextSharp.LGPLv2.Core

Issues with encoding.
Encoding issues.
The simple PDF generated by the library itself can be read, but another PDF tested returns problems with encoding.

- [SimpleTextExtractionStrategy ?](https://github.com/VahidN/iTextSharp.LGPLv2.Core/issues/7)
Comment on lines 36 to 42
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CODE REVIEW

  1. Improved wording for clarity:
-Issues with encoding.
+Encoding issues.

  1. Please add a description of encoding issues. This can help in understanding the problem better.

  2. The outdated URL format can be updated:

- [SimpleTextExtractionStrategy ?](https://github.com/VahidN/iTextSharp.LGPLv2.Core/issues/7)
+ [SimpleTextExtractionStrategy?](https://github.com/VahidN/iTextSharp.LGPLv2.Core/issues/7)

Remember to use bullet points consistently for lists.

Expand Down