Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: new verify timeout config feature #8801

Merged
merged 4 commits into from
Jun 16, 2023

Conversation

renzodavid9
Copy link
Contributor

@renzodavid9 renzodavid9 commented May 18, 2023

Fixes: #7366

Description
This PR adds the needed logic to support the configuration of a user define time out for every verify test case, for docker and k8s implementations.

User facing changes
This PR includes a schema upgrade.

  • Now the verify stanza supports a timeout field:
verify:
- name: alpine-1
  timeout: 5
  container:
    name: alpine-1
    image: alpine:3.15.4
    command: ["/bin/sh"]
    args: ["-c", "echo alpine-1; sleep 10; echo bye alpine-1"]```

@renzodavid9 renzodavid9 changed the title Issue 7366 feat: new verify timeout config feature May 18, 2023
@codecov
Copy link

codecov bot commented May 18, 2023

Codecov Report

Merging #8801 (b4f875e) into main (290280e) will decrease coverage by 6.71%.
The diff coverage is 48.99%.

@@            Coverage Diff             @@
##             main    #8801      +/-   ##
==========================================
- Coverage   70.48%   63.77%   -6.71%     
==========================================
  Files         515      622     +107     
  Lines       23150    31585    +8435     
==========================================
+ Hits        16317    20144    +3827     
- Misses       5776     9931    +4155     
- Partials     1057     1510     +453     
Impacted Files Coverage Δ
cmd/skaffold/app/cmd/completion.go 13.04% <0.00%> (-1.25%) ⬇️
cmd/skaffold/app/cmd/config/list.go 65.21% <ø> (ø)
cmd/skaffold/app/cmd/config/set.go 88.72% <ø> (ø)
cmd/skaffold/app/cmd/config/util.go 54.28% <ø> (ø)
cmd/skaffold/app/cmd/credits.go 100.00% <ø> (ø)
cmd/skaffold/app/cmd/credits/export.go 0.00% <0.00%> (ø)
cmd/skaffold/app/cmd/deploy.go 40.90% <0.00%> (-12.94%) ⬇️
cmd/skaffold/app/cmd/generate_pipeline.go 60.00% <ø> (ø)
cmd/skaffold/app/cmd/inspect_modules.go 65.00% <ø> (ø)
cmd/skaffold/app/cmd/inspect_profiles.go 66.66% <ø> (ø)
... and 40 more

... and 412 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@renzodavid9 renzodavid9 force-pushed the issue-7366 branch 5 times, most recently from 08fa63c to 9407cae Compare May 24, 2023 17:23
@renzodavid9 renzodavid9 added the kokoro:force-run forces a kokoro re-run on a PR label May 24, 2023
@kokoro-team kokoro-team removed the kokoro:force-run forces a kokoro re-run on a PR label May 24, 2023
@renzodavid9 renzodavid9 marked this pull request as ready for review May 24, 2023 18:54
@renzodavid9 renzodavid9 requested a review from a team as a code owner May 24, 2023 18:54
@renzodavid9 renzodavid9 marked this pull request as draft June 9, 2023 18:00
@renzodavid9 renzodavid9 removed the request for review from aaron-prindle June 9, 2023 18:00
@renzodavid9 renzodavid9 added the kokoro:force-run forces a kokoro re-run on a PR label Jun 9, 2023
@kokoro-team kokoro-team removed the kokoro:force-run forces a kokoro re-run on a PR label Jun 9, 2023
@renzodavid9 renzodavid9 marked this pull request as ready for review June 12, 2023 14:41
@renzodavid9 renzodavid9 requested review from plumpy and removed request for a team June 12, 2023 14:41
@renzodavid9 renzodavid9 merged commit 8f8b40b into GoogleContainerTools:main Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(verify): add user configurable timeout to skaffold verify
3 participants