Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(verify): add user configurable timeout to skaffold verify #7366

Closed
aaron-prindle opened this issue May 2, 2022 · 1 comment · Fixed by #8801
Closed

feat(verify): add user configurable timeout to skaffold verify #7366

aaron-prindle opened this issue May 2, 2022 · 1 comment · Fixed by #8801
Assignees
@renzodavid9
Labels
area/verify Issues related to skaffold verify command kind/feature-request kind/todo implementation task/epic for the skaffold team priority/p1 High impact feature/bug.
Milestone
v2.6.0

Comments

@aaron-prindle
Copy link
Contributor

aaron-prindle commented May 2, 2022 •
edited
Loading

Currently the timeout for skaffold verify is hardcoded to 10minutes for each test. This should be user configurable via the verify schema or a CLI flag to enable longer/shorter running tests if desired by the user
@aaron-prindle aaron-prindle added the kind/todo implementation task/epic for the skaffold team label May 2, 2022
@aaron-prindle aaron-prindle changed the title Skaffold verify - add user configurable timeout feat(verify): add user configurable timeout to skaffold verify May 2, 2022
@aaron-prindle aaron-prindle added area/verify Issues related to skaffold verify command kind/feature-request priority/p1 High impact feature/bug. labels May 2, 2022
@aaron-prindle aaron-prindle added this to the v2.2.0 milestone Feb 7, 2023
@aaron-prindle aaron-prindle modified the milestones: v2.2.0, v2.3.0 Mar 7, 2023
@aaron-prindle aaron-prindle modified the milestones: v2.3.0, v2.4.0 Apr 3, 2023
@aaron-prindle aaron-prindle self-assigned this Apr 3, 2023
@aaron-prindle aaron-prindle modified the milestones: v2.4.0, v2.5.0 Apr 27, 2023
@renzodavid9
Copy link
Contributor

The behaviour should be:

  • Per default, no timeout
  • If the user configures it, have a time out for docker and k8s verify test cases

We'll need to do an schema upgrade for this.

@renzodavid9 renzodavid9 mentioned this issue May 18, 2023
Merged
@aaron-prindle aaron-prindle modified the milestones: v2.5.0, v2.6.0 May 25, 2023
@renzodavid9 renzodavid9 mentioned this issue Jun 5, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@renzodavid9 renzodavid9

Labels
area/verify Issues related to skaffold verify command kind/feature-request kind/todo implementation task/epic for the skaffold team priority/p1 High impact feature/bug.
Projects
None yet
Milestone
v2.6.0
Development

Successfully merging a pull request may close this issue.

feat: new verify timeout config feature renzodavid9/skaffold
2 participants
@aaron-prindle @renzodavid9