Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correctly rewrite /deploy/kubectl/manifests in patch upgrades #8585

Merged

Conversation

mrob95
Copy link
Contributor

@mrob95 mrob95 commented Mar 24, 2023

Fixes: #8564

Description
This looks like a fairly simple fix to me. #7800 added functionality to rewrite yaml paths in patches during v2->v3 upgrades. Only /deploy/kubectl/manifests should be rewritten to /manifests/rawYaml though, not all of /deploy/kubectl.

@google-cla
Copy link

google-cla bot commented Mar 24, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@codecov
Copy link

codecov bot commented Mar 24, 2023

Codecov Report

Merging #8585 (89756ff) into main (290280e) will decrease coverage by 6.24%.
The diff coverage is 54.32%.

@@            Coverage Diff             @@
##             main    #8585      +/-   ##
==========================================
- Coverage   70.48%   64.24%   -6.24%     
==========================================
  Files         515      610      +95     
  Lines       23150    30579    +7429     
==========================================
+ Hits        16317    19646    +3329     
- Misses       5776     9461    +3685     
- Partials     1057     1472     +415     
Impacted Files Coverage Δ
cmd/skaffold/app/cmd/completion.go 13.04% <0.00%> (-1.25%) ⬇️
cmd/skaffold/app/cmd/config/list.go 65.21% <ø> (ø)
cmd/skaffold/app/cmd/config/set.go 88.72% <ø> (ø)
cmd/skaffold/app/cmd/config/util.go 54.28% <ø> (ø)
cmd/skaffold/app/cmd/credits.go 100.00% <ø> (ø)
cmd/skaffold/app/cmd/credits/export.go 0.00% <0.00%> (ø)
cmd/skaffold/app/cmd/deploy.go 40.90% <0.00%> (-12.94%) ⬇️
cmd/skaffold/app/cmd/generate_pipeline.go 60.00% <ø> (ø)
cmd/skaffold/app/cmd/inspect_modules.go 65.00% <ø> (ø)
cmd/skaffold/app/cmd/inspect_profiles.go 66.66% <ø> (ø)
... and 38 more

... and 388 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ericzzzzzzz ericzzzzzzz merged commit e0fea66 into GoogleContainerTools:main Mar 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

skaffold fix generates wrong yaml path for deploy/kubectl/manifests
2 participants