Skip to content

Commit

Permalink
fix: correctly rewrite /deploy/kubectl/manifests in patch upgrades (#…
Browse files Browse the repository at this point in the history
  • Loading branch information
mrob95 authored Mar 25, 2023
1 parent 4694d64 commit e0fea66
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 2 deletions.
2 changes: 1 addition & 1 deletion pkg/skaffold/schema/v2beta29/upgrade.go
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ import (
var artifactOverridesRegexp = regexp.MustCompile("/deploy/helm/releases/[0-9]+/artifactOverrides/image")

var migrations = map[string]string{
"/deploy/kubectl": "/manifests/rawYaml",
"/deploy/kubectl/manifests": "/manifests/rawYaml",
"/deploy/kustomize/paths": "/manifests/kustomize/paths",
"/deploy/kustomize/buildArgs": "/manifests/kustomize/buildArgs",
"/deploy/helm": "/manifests/helm",
Expand Down
6 changes: 5 additions & 1 deletion pkg/skaffold/schema/v2beta29/upgrade_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -245,7 +245,9 @@ profiles:
- name: kustomize
patches:
- op: remove
path: /deploy/kubectl
path: /deploy/kubectl/manifests
- op: remove
path: /deploy/kubectl/manifests/0
- op: remove
path: /deploy/helm
deploy:
Expand Down Expand Up @@ -273,6 +275,8 @@ profiles:
patches:
- op: remove
path: /manifests/rawYaml
- op: remove
path: /manifests/rawYaml/0
- op: remove
path: /manifests/helm
- op: remove
Expand Down

0 comments on commit e0fea66

Please sign in to comment.