-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewrite policy-controller-validate with kyaml #197
Merged
Merged
Changes from 9 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
58b7afb
Initial commit
frankfarzan 17ac09a
Add short flags and usage to gatekeeper function.
frankfarzan 367eacf
Upgrade OPA constraint framework (#132)
maxsmythe 25977a4
Log violated constraint
prachirp 5c25827
Move validate.go to the desired dir after running git filter-branch
245c206
Merge the history of kpt-functions-sdk/go/pkg/functions/gatekeeper/
7d6a45e
Migrate policy-controller-validate to use kyaml
c636365
code review
b191217
rename fn to gatekeeper-validate
48f2802
Support different enforcement levels
4b3378e
code review
546c983
code review
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
2 changes: 2 additions & 0 deletions
2
examples/validators/gatekeeper-validate/invalid-configmap/.expected/config.yaml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
exitCode: 1 | ||
runCount: 2 |
14 changes: 14 additions & 0 deletions
14
examples/validators/gatekeeper-validate/invalid-configmap/.expected/results.yaml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
items: | ||
- message: |- | ||
The following banned keys are being used in the config map: {"private_key"} | ||
violatedConstraint: no-secrets-in-configmap | ||
severity: error | ||
resourceRef: | ||
apiVersion: v1 | ||
kind: ConfigMap | ||
metadata: | ||
name: super-secret | ||
namespace: default | ||
file: | ||
path: resources.yaml | ||
index: 2 |
1 change: 1 addition & 0 deletions
1
examples/validators/gatekeeper-validate/invalid-configmap/.krmignore
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
.expected |
73 changes: 73 additions & 0 deletions
73
examples/validators/gatekeeper-validate/invalid-configmap/README.md
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,73 @@ | ||
# gatekeeper-validate: invalid configmap | ||
|
||
## Overview | ||
|
||
This example demonstrates how to validate config maps using a constraint. | ||
mengqiy marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
There are 3 resources: a ConstraintTemplate, a K8sBannedConfigMapKeysV1 and a | ||
ConfigMap. | ||
The constraint disallows `private_key` to be used as a key in the config map. | ||
mengqiy marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
## Function invocation | ||
|
||
Get the package: | ||
|
||
```shell | ||
$ kpt pkg get https://github.com/GoogleContainerTools/kpt-functions-catalog.git/examples/validators/gatekeeper-validate/invalid-configmap . | ||
``` | ||
|
||
Create a directory for storing the structured output. | ||
|
||
```shell | ||
$ cd invalid-configmap | ||
$ mkdir results | ||
``` | ||
|
||
Run the function: | ||
|
||
```shell | ||
$ kpt fn run --results-dir=results . | ||
``` | ||
|
||
## Expected result | ||
|
||
You should see the following output: | ||
|
||
``` | ||
The following banned keys are being used in the config map: {"private_key"} | ||
violatedConstraint: no-secrets-in-configmaperror: exit status 1 | ||
``` | ||
|
||
Let's take a look at the structured output: | ||
|
||
```shell | ||
$ cat results/results-0.yaml | ||
items: | ||
- message: |- | ||
The following banned keys are being used in the config map: {"private_key"} | ||
violatedConstraint: no-secrets-in-configmap | ||
severity: error | ||
resourceRef: | ||
apiVersion: v1 | ||
kind: ConfigMap | ||
metadata: | ||
name: super-secret | ||
namespace: default | ||
file: | ||
path: resources.yaml | ||
index: 2 | ||
``` | ||
|
||
You can find: | ||
- a detailed error message | ||
- what resource violates the constraints | ||
- what constraint does it violate | ||
- where does the resource live and its index in the file | ||
|
||
To pass validation, let's replace the key `private_key` in the ConfigMap in | ||
`resources.yaml` with something else e.g. `public_key`. | ||
Rerun the command. It will succeed (no output). | ||
|
||
## Function Reference | ||
mengqiy marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
TODO: add the link |
9 changes: 9 additions & 0 deletions
9
examples/validators/gatekeeper-validate/invalid-configmap/fn-config.yaml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
apiVersion: v1 | ||
kind: ConfigMap | ||
metadata: | ||
name: my-func-config | ||
annotations: | ||
config.k8s.io/function: | | ||
container: | ||
image: gcr.io/kpt-fn/gatekeeper-validate:unstable | ||
config.kubernetes.io/local-config: 'true' |
51 changes: 51 additions & 0 deletions
51
examples/validators/gatekeeper-validate/invalid-configmap/resources.yaml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,51 @@ | ||
apiVersion: templates.gatekeeper.sh/v1beta1 | ||
kind: ConstraintTemplate | ||
metadata: | ||
name: k8sbannedconfigmapkeysv1 | ||
spec: | ||
crd: | ||
spec: | ||
names: | ||
kind: K8sBannedConfigMapKeysV1 | ||
validation: | ||
openAPIV3Schema: | ||
properties: | ||
keys: | ||
type: array | ||
items: | ||
type: string | ||
targets: | ||
- target: admission.k8s.gatekeeper.sh | ||
rego: |- | ||
package ban_keys | ||
|
||
violation[{"msg": sprintf("%v", [val])}] { | ||
keys = {key | input.review.object.data[key]} | ||
banned = {key | input.parameters.keys[_] = key} | ||
overlap = keys & banned | ||
count(overlap) > 0 | ||
val := sprintf("The following banned keys are being used in the config map: %v", [overlap]) | ||
} | ||
--- | ||
apiVersion: constraints.gatekeeper.sh/v1beta1 | ||
kind: K8sBannedConfigMapKeysV1 | ||
metadata: | ||
name: no-secrets-in-configmap | ||
spec: | ||
match: | ||
kinds: | ||
- apiGroups: | ||
- '' | ||
kinds: | ||
- ConfigMap | ||
parameters: | ||
keys: | ||
- private_key | ||
--- | ||
apiVersion: v1 | ||
kind: ConfigMap | ||
metadata: | ||
name: super-secret | ||
namespace: default | ||
data: | ||
private_key: sensitive data goes here |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
FROM golang:1.15-alpine3.12 | ||
ENV CGO_ENABLED=0 | ||
WORKDIR /go/src/ | ||
|
||
COPY go.mod go.sum ./ | ||
RUN go mod download | ||
|
||
COPY . . | ||
RUN go build -o /usr/local/bin/validate ./ | ||
|
||
############################################# | ||
|
||
FROM alpine:3.12 | ||
COPY --from=0 /usr/local/bin/validate /usr/local/bin/validate | ||
ENTRYPOINT ["validate"] |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,41 @@ | ||
# gatekeeper-validate | ||
|
||
### Overview | ||
|
||
<!--mdtogo:Short--> | ||
|
||
Validate the KRM resources using the policy controller. | ||
mengqiy marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
<!--mdtogo--> | ||
|
||
### Synopsis | ||
|
||
<!--mdtogo:Long--> | ||
|
||
You can use the policy controller to validate KRM resources. To learn more about | ||
the policy controller, see: https://cloud.google.com/anthos-config-management/docs/concepts/policy-controller. | ||
mengqiy marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
The function ensures the constraint policies are enforced on KRM resources. | ||
mengqiy marked this conversation as resolved.
Show resolved
Hide resolved
|
||
The function takes 3 types of resources from the input resource list: | ||
|
||
- constraint templates | ||
- constraints | ||
- other KRM resources | ||
|
||
Every constraint should be backed by a constraint template that defines the | ||
schema and logic of the constraint. | ||
|
||
To learn more about how to write constraint templates and constraints, see: | ||
https://cloud.google.com/anthos-config-management/docs/how-to/write-a-constraint-template | ||
and | ||
https://cloud.google.com/anthos-config-management/docs/how-to/creating-constraints. | ||
|
||
<!--mdtogo--> | ||
|
||
### Examples | ||
|
||
<!--mdtogo:Examples--> | ||
|
||
TODO: link to the examples | ||
mengqiy marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
<!--mdtogo--> |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
module github.com/GoogleContainerTools/kpt-functions-catalog/functions/go/gatekeeper-validate | ||
|
||
go 1.15 | ||
|
||
require ( | ||
github.com/open-policy-agent/frameworks/constraint v0.0.0-20210317225149-4f80ac172ddf | ||
github.com/open-policy-agent/gatekeeper v3.0.4-beta.2+incompatible | ||
mengqiy marked this conversation as resolved.
Show resolved
Hide resolved
|
||
k8s.io/apimachinery v0.17.2 | ||
sigs.k8s.io/kustomize/kyaml v0.10.13 | ||
sigs.k8s.io/yaml v1.2.0 | ||
) |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a TODO to test expected CLI output? (My previous comment)
This is important part of the UX.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding it to the
.expected
directory messes up with the test.I filed kptdev/kpt#1689 and added in m2 milestone.