Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

We should test the expected CLI output in function catalog tests #1689

Closed
mengqiy opened this issue Apr 5, 2021 · 2 comments
Closed

We should test the expected CLI output in function catalog tests #1689

mengqiy opened this issue Apr 5, 2021 · 2 comments
Labels
area/fn-catalog Functions Catalog triaged Issue has been triaged by adding an `area/` label

Comments

@mengqiy
Copy link
Contributor

mengqiy commented Apr 5, 2021

The CLI output will be the only thing that a user can see when the user doesn't use structured output.
We should test the expected CLI output ensure that the CLI output itself contains reasonable enough information for functions.
@mengqiy mengqiy added area/fn-catalog Functions Catalog triaged Issue has been triaged by adding an `area/` label labels Apr 5, 2021
@mengqiy mengqiy added this to the v1.0 m2 milestone Apr 5, 2021
@mengqiy mengqiy mentioned this issue Apr 5, 2021
Merged
@Shell32-Natsu
Copy link
Contributor

Isn't this duplicated with #1666?

@mengqiy mengqiy removed this from the v1.0 m2 milestone Apr 5, 2021
@mengqiy
Copy link
Contributor Author

mengqiy commented Apr 5, 2021

You are right.

@mengqiy mengqiy closed this as completed Apr 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/fn-catalog Functions Catalog triaged Issue has been triaged by adding an `area/` label
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mengqiy @Shell32-Natsu