Update README for skaffold config #2304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loosebazooka
added
the
PR: Merge After Release
TadCordle
reviewed
Feb 25, 2020
Co-Authored-By: Tad Cordle <[email protected]>
Co-Authored-By: Tad Cordle <[email protected]>
This section? |
|
Yeah, since all the other closures are listed there, maybe we should link to the skaffold one. |
TadCordle
reviewed
Feb 26, 2020
jib-gradle-plugin/README.md
Outdated
| @@ -189,6 +190,7 @@ Field | Type | Default | Description | |||
| `dockerClient` | [`dockerClient`](#dockerclient-closure) | See [`dockerClient`](#dockerclient-closure) | Configures Docker for building to/from the Docker daemon. | |||
| `containerizingMode` | `String` | `exploded` | If set to `packaged`, puts the JAR artifact built by the Gradle Java plugin into the final image. If set to `exploded` (default), containerizes individual `.class` files and resources files. | |||
| `allowInsecureRegistries` | `boolean` | `false` | If set to true, Jib ignores HTTPS certificate errors and may fall back to HTTP as a last resort. Leaving this parameter set to `false` is strongly recommended, since HTTP communication is unencrypted and visible to others on the network, and insecure HTTPS is no better than plain HTTP. [If accessing a registry with a self-signed certificate, adding the certificate to your Java runtime's trusted keys](https://github.com/GoogleContainerTools/jib/tree/master/docs/self_sign_cert.md) may be an alternative to enabling this option. | |||
| `skaffold` | [`skaffold`](#skaffold-integration) | *None* | Configures the internal skaffold tasks. This configuration should only be used when integrating with [`skaffold`](#skaffold-integration) | | |||
There was a problem hiding this comment.
Maybe we should move it up with the other closures (underneath dockerClient)
There was a problem hiding this comment.
Also, similarly to the other closures, we should put
See [`skaffold`](#skaffold-integration)
in the default value field instead of None?
There was a problem hiding this comment.
I'm not sure what you mean by field? I think None is appropriate?
There was a problem hiding this comment.
Oh I see, link to the (skaffold-integration) section?
There was a problem hiding this comment.
Sorry, I mean the Default column. Just trying to mimic what the other closures do in the table.
TadCordle
reviewed
Feb 26, 2020
chanseokoh
removed
the
PR: Merge After Release
|
Time to merge this? |
Co-Authored-By: Tad Cordle <[email protected]>
Co-Authored-By: Tad Cordle <[email protected]>
Co-Authored-By: Tad Cordle <[email protected]>
Co-Authored-By: Tad Cordle <[email protected]>
Co-Authored-By: Tad Cordle <[email protected]>
Co-Authored-By: Tad Cordle <[email protected]>
|
Ah yeah, will do after Tad's suggestions go though. |
TadCordle
approved these changes
Mar 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
merge after 2.1.0, README updates for #2292