Allow users to configure skaffold data exported from jib to skaffold #2292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loosebazooka
force-pushed
the
gradle-skaffold-config-options
branch
3 times, most recently
from
f4fa3fe to
8224c60
Compare
loosebazooka
changed the title
|
@loosebazooka I tested this patch in my project and it seems to work as intended. |
...-plugin/src/main/java/com/google/cloud/tools/jib/gradle/skaffold/SkaffoldSyncParameters.java
Outdated
Show resolved
Hide resolved
...plugin/src/main/java/com/google/cloud/tools/jib/gradle/skaffold/SkaffoldWatchParameters.java
Outdated
Show resolved
Hide resolved
...plugin/src/main/java/com/google/cloud/tools/jib/gradle/skaffold/SkaffoldWatchParameters.java
Show resolved
Hide resolved
TadCordle
reviewed
Feb 18, 2020
...adle-plugin/src/main/java/com/google/cloud/tools/jib/gradle/skaffold/SkaffoldParameters.java
Show resolved
Hide resolved
...-plugin/src/main/java/com/google/cloud/tools/jib/gradle/skaffold/SkaffoldSyncParameters.java
Show resolved
Hide resolved
...plugin/src/main/java/com/google/cloud/tools/jib/gradle/skaffold/SkaffoldWatchParameters.java
Show resolved
Hide resolved
TadCordle
reviewed
Feb 18, 2020
jib-maven-plugin/src/main/java/com/google/cloud/tools/jib/maven/skaffold/FilesMojoV2.java
Outdated
Show resolved
Hide resolved
TadCordle
reviewed
Feb 18, 2020
...en-plugin/src/main/java/com/google/cloud/tools/jib/maven/skaffold/SkaffoldConfiguration.java
Show resolved
Hide resolved
...on/src/main/java/com/google/cloud/tools/jib/plugins/common/PluginConfigurationProcessor.java
Outdated
Show resolved
Hide resolved
|
I'm going to avoid properties for now... but nothing stops us from adding them in the future. Although I can see how someone would want different configs for different skaffold runs, but that can always be done with profiles, project-properties. |
chanseokoh
reviewed
Feb 18, 2020
jib-gradle-plugin/src/test/java/com/google/cloud/tools/jib/gradle/JibExtensionTest.java
Outdated
Show resolved
Hide resolved
...en-plugin/src/main/java/com/google/cloud/tools/jib/maven/skaffold/SkaffoldConfiguration.java
Show resolved
Hide resolved
jib-gradle-plugin/src/main/java/com/google/cloud/tools/jib/gradle/skaffold/SyncMapTask.java
Show resolved
Hide resolved
briandealwis
approved these changes
Feb 20, 2020
...on/src/main/java/com/google/cloud/tools/jib/plugins/common/PluginConfigurationProcessor.java
Show resolved
Hide resolved
loosebazooka
force-pushed
the
gradle-skaffold-config-options
branch
from
abd7b41 to
4b7ff2b
Compare
|
Uh I added a few new changelog/readme changes, would be helpful if someone looks at them before I submit. |
loosebazooka
force-pushed
the
gradle-skaffold-config-options
branch
from
4b7ff2b to
6227754
Compare
|
Can you move the readme stuff to another PR so we don't merge it until after release? |
|
oh right, good point. |
TadCordle
approved these changes
Feb 21, 2020
Co-Authored-By: Tad Cordle <[email protected]>
Co-Authored-By: Tad Cordle <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of proposal at: https://github.com/GoogleContainerTools/jib/blob/master/proposals/skaffold_config.md