-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow Disabling Service Accounts #5169
Conversation
Co-authored-by: upodroid <[email protected]>
Hello! I am a robot who works on Magic Modules PRs. I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review. Thanks for your contribution! A human will be with you soon. @melinath, please review this PR or find an appropriate assignee. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems reasonable; one question about the tests and a quick change request for the docs.
mmv1/third_party/terraform/tests/resource_google_service_account_test.go
Show resolved
Hide resolved
mmv1/third_party/terraform/website/docs/r/google_service_account.html.markdown
Outdated
Show resolved
Hide resolved
/gcbrun |
I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccComputeOrganizationSecurityPolicyAssociation_organizationSecurityPolicyAssociationBasicExample|TestAccFirebaseWebApp_firebaseWebAppBasicExample|TestAccServiceAccount_Disabled You can view the result here: https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=204740 |
Tests failed during RECORDING mode: TestAccFirebaseWebApp_firebaseWebAppBasicExample|TestAccComputeOrganizationSecurityPolicyAssociation_organizationSecurityPolicyAssociationBasicExample Please fix these to complete your PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* allow disabling service accounts Co-authored-by: upodroid <[email protected]> * fix typos * revert warning change
Fixes: hashicorp/terraform-provider-google#9824
Closes: hashicorp/terraform-provider-google#9954
If this PR is for Terraform, I acknowledge that I have:
make test
andmake lint
to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)