Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promote release_channel to GA for GKE #3834

Merged
merged 2 commits into from
Aug 6, 2020

Conversation

upodroid
Copy link
Contributor

@upodroid upodroid commented Aug 6, 2020

Fixes: hashicorp/terraform-provider-google#6390

Release Note Template for Downstream PRs (will be copied)

container: added `release_channel` to `google_container-cluster` (GA)

@google-cla google-cla bot added the cla: yes label Aug 6, 2020
@modular-magician
Copy link
Collaborator

Hello! I am a robot who works on Magic Modules PRs.

I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review.

Thanks for your contribution! A human will be with you soon.

@rileykarson, please review this PR or find an appropriate assignee.

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 2 files changed, 175 insertions(+))
Terraform Beta: Diff ( 1 file changed, 28 insertions(+), 43 deletions(-))

@upodroid upodroid force-pushed the ga-releasechannel branch from cd07976 to 8c12f87 Compare August 6, 2020 15:59
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 2 files changed, 180 insertions(+))
Terraform Beta: Diff ( 1 file changed, 28 insertions(+), 28 deletions(-))

Copy link
Member

@rileykarson rileykarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @upodroid!

@nat-henderson
Copy link
Contributor

nat-henderson commented Aug 6, 2020

@@ -2939,7 +2939,6 @@ func expandDatabaseEncryption(configured interface{}) *containerBeta.DatabaseEnc
}
}

<% unless version == 'ga' -%>
func expandReleaseChannel(configured interface{}) *containerBeta.ReleaseChannel {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you need a nil check here before the attempt at a cast; if l == nil { return nil }.

@rileykarson
Copy link
Member

Oh whoops, I forgot that VCR doesn't run on community PRs. Makes sense! I see you sent #3836.

@upodroid
Copy link
Contributor Author

upodroid commented Aug 6, 2020

Hi, was it broken in the beta one too?

@nat-henderson
Copy link
Contributor

It didn't seem to be, which is a little odd! I am waiting for the tests to come back to be sure that this is the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make google_container_cluster release_channel GA
4 participants