-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Promote release_channel to GA for GKE #3834
Promote release_channel to GA for GKE #3834
Conversation
Fork Update
Hello! I am a robot who works on Magic Modules PRs. I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review. Thanks for your contribution! A human will be with you soon. @rileykarson, please review this PR or find an appropriate assignee. |
cd07976
to
8c12f87
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @upodroid!
I'm suspicious that this change broke the GKE tests. |
@@ -2939,7 +2939,6 @@ func expandDatabaseEncryption(configured interface{}) *containerBeta.DatabaseEnc | |||
} | |||
} | |||
|
|||
<% unless version == 'ga' -%> | |||
func expandReleaseChannel(configured interface{}) *containerBeta.ReleaseChannel { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you need a nil check here before the attempt at a cast; if l == nil { return nil }.
Oh whoops, I forgot that VCR doesn't run on community PRs. Makes sense! I see you sent #3836. |
Hi, was it broken in the beta one too? |
It didn't seem to be, which is a little odd! I am waiting for the tests to come back to be sure that this is the issue. |
Fixes: hashicorp/terraform-provider-google#6390
Release Note Template for Downstream PRs (will be copied)