Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make google_container_cluster release_channel GA #6390

Closed
gleichda opened this issue May 15, 2020 · 7 comments · Fixed by GoogleCloudPlatform/magic-modules#3834, #6955 or hashicorp/terraform-provider-google-beta#2343

Comments

@gleichda
Copy link

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment. If the issue is assigned to the "modular-magician" user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If the issue is assigned to a user, that user is claiming responsibility for the issue. If the issue is assigned to "hashibot", a community member has claimed the issue already.

Description

As from the documentation Release Channels are now GA but in Terraform they are still beta. Would be awesome if you could bring them to GA in Terraform also.

New or Affected Resource(s)

  • google_container_cluster

References

Documentation: https://cloud.google.com/kubernetes-engine/docs/concepts/release-channels Terraform Docs: https://www.terraform.io/docs/providers/google/r/container_cluster.html#release_channel

  • #0000
@ghost ghost added the enhancement label May 15, 2020
@gowrisankar22
Copy link

gowrisankar22 commented May 16, 2020

dupe of #5391

@gleichda
Copy link
Author

@gowrisankar22 Not really as release channels are now GA

@danawillow
Copy link
Contributor

@gleichda
Copy link
Author

Only enrolling an existing cluster with Release Channels but not creating a new cluster with release channels? Or did I miss something?

@danawillow
Copy link
Contributor

Regardless, the API doesn't have support for it in GA yet: https://cloud.google.com/kubernetes-engine/docs/reference/rest/v1/projects.locations.clusters (vs https://cloud.google.com/kubernetes-engine/docs/reference/rest/v1beta1/projects.locations.clusters, search for ReleaseChannel)

@steinbrueckri
Copy link

As you could check in the documentation about GKE v1 API projects.locations.clusters, nowadays the feature ReleaseChannel is in GA since yesterday. 🙌

@ghost
Copy link

ghost commented Sep 6, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Sep 6, 2020
@github-actions github-actions bot added service/container forward/review In review; remove label to forward labels Jan 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.