Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: (storageinsights) added field parquet_options in google_storage_insights_report_config #13178

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

gurusai-voleti
Copy link
Contributor

Fixes: hashicorp/terraform-provider-google#16442
Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

storageinsights: added `parquet_options` field to `google_storage_insights_report_config` resource

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 232 insertions(+), 27 deletions(-))
google-beta provider: Diff ( 4 files changed, 232 insertions(+), 27 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 16 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 4
Passed tests: 0
Skipped tests: 0
Affected tests: 4

Click here to see the affected service packages
  • storageinsights

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccStorageInsightsReportConfig_parquet
  • TestAccStorageInsightsReportConfig_reportTypeConflict
  • TestAccStorageInsightsReportConfig_storageInsightsReportConfigExample
  • TestAccStorageInsightsReportConfig_update

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccStorageInsightsReportConfig_parquet [Debug log]
TestAccStorageInsightsReportConfig_reportTypeConflict [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccStorageInsightsReportConfig_reportTypeConflict [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.


🔴 Tests failed during RECORDING mode:
TestAccStorageInsightsReportConfig_storageInsightsReportConfigExample [Error message] [Debug log]
TestAccStorageInsightsReportConfig_update [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@gurusai-voleti gurusai-voleti changed the title feat: (storageinsights) added support for field parquet_options feat: (storageinsights) added field parquet_options in google_storage_insights_report_config Feb 25, 2025
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 238 insertions(+), 27 deletions(-))
google-beta provider: Diff ( 4 files changed, 238 insertions(+), 27 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 21 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 4
Passed tests: 0
Skipped tests: 0
Affected tests: 4

Click here to see the affected service packages
  • storageinsights

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccStorageInsightsReportConfig_parquet
  • TestAccStorageInsightsReportConfig_reportTypeConflict
  • TestAccStorageInsightsReportConfig_storageInsightsReportConfigExample
  • TestAccStorageInsightsReportConfig_update

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccStorageInsightsReportConfig_storageInsightsReportConfigExample [Debug log]
TestAccStorageInsightsReportConfig_update [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🔴 Tests failed during RECORDING mode:
TestAccStorageInsightsReportConfig_parquet [Error message] [Debug log]
TestAccStorageInsightsReportConfig_reportTypeConflict [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 238 insertions(+), 27 deletions(-))
google-beta provider: Diff ( 4 files changed, 238 insertions(+), 27 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 21 insertions(+))

1 similar comment
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 238 insertions(+), 27 deletions(-))
google-beta provider: Diff ( 4 files changed, 238 insertions(+), 27 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 21 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 4
Passed tests: 3
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages
  • storageinsights

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccStorageInsightsReportConfig_reportTypeConflict

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccStorageInsightsReportConfig_reportTypeConflict [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccStorageInsightsReportConfig_reportTypeConflict [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.


🟢 All tests passed!

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 4
Passed tests: 3
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages
  • storageinsights

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccStorageInsightsReportConfig_reportTypeConflict

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccStorageInsightsReportConfig_reportTypeConflict [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccStorageInsightsReportConfig_reportTypeConflict [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.


🟢 All tests passed!

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 163 insertions(+), 27 deletions(-))
google-beta provider: Diff ( 4 files changed, 163 insertions(+), 27 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 21 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 3
Passed tests: 3
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • storageinsights

🟢 All tests passed!

View the build log

@gurusai-voleti gurusai-voleti marked this pull request as ready for review February 26, 2025 06:06
Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@slevenick, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@github-actions github-actions bot requested a review from slevenick February 26, 2025 06:07
Copy link
Contributor

@slevenick slevenick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a test that changes from having parquet_options set to having csv_options set and the other way as well? Just to make sure the update functionality works for moving between them

@github-actions github-actions bot requested a review from slevenick February 28, 2025 04:24
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 161 insertions(+), 27 deletions(-))
google-beta provider: Diff ( 4 files changed, 161 insertions(+), 27 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 21 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 3
Passed tests: 3
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • storageinsights

🟢 All tests passed!

View the build log

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 161 insertions(+), 27 deletions(-))
google-beta provider: Diff ( 4 files changed, 161 insertions(+), 27 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 21 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 3
Passed tests: 3
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • storageinsights

🟢 All tests passed!

View the build log

ProtoV5ProviderFactories: acctest.ProtoV5ProviderFactories(t),
Steps: []resource.TestStep{
{
Config: testAccStorageInsightsReportConfig_parquet(context),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add another test step here that uses the same resource and removes the parquet option and adds the CSV option?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

google_storage_insights_report_config should support the output type of Parquet
3 participants