Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

google_storage_insights_report_config should support the output type of Parquet #16442

Open
philip-harvey opened this issue Nov 3, 2023 · 1 comment · May be fixed by GoogleCloudPlatform/magic-modules#13178

Comments

@philip-harvey
Copy link

philip-harvey commented Nov 3, 2023

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment. If the issue is assigned to the "modular-magician" user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If the issue is assigned to a user, that user is claiming responsibility for the issue. If the issue is assigned to "hashibot", a community member has claimed the issue already.

Description

google_storage_insights_report_config should support the output type of Parquet, currently it only supports CSV

New or Affected Resource(s)

google_storage_insights_report_config

Potential Terraform Configuration

resource "google_storage_insights_report_config" "config" {
  display_name = "Test Report Config"
  location = "us-central1"
  parquet_options = {}
  frequency_options {
    frequency = "WEEKLY"
    start_date {
      day = 15
      month = 3
      year = 2050
    }
    end_date {
      day = 15
      month = 4
      year = 2050
    }
  }
  object_metadata_report_options {
    metadata_fields = ["bucket", "name", "project"]
    storage_filters {
      bucket = google_storage_bucket.report_bucket.name
    }
    storage_destination_options {
      bucket = google_storage_bucket.report_bucket.name
      destination_path = "test-insights-reports"
    }
  }
}

References

https://cloud.google.com/storage/docs/json_api/v1/reportConfig

b/309602137

@Ouwen
Copy link

Ouwen commented Mar 16, 2024

Just to understand this would involve the following:

  1. Update the schema

  2. Add a check for the parquet_options param on create, read, update, and update change.

  3. Write tests to cover this new param

I'm a bit new to the community, but would be interested in trying to contribute this if someone is willing to give some pointers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants