Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promoting namespace to the GA provider #12644

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Promoting namespace to the GA provider #12644

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
e1b2d6e
Create service_directory_namespace_ga.tf.tmpl
erikmej-code Dec 23, 2024
8f21d5d
Update Namespace.yaml
erikmej-code Dec 23, 2024
1dc3764
Delete mmv1/templates/terraform/examples/service_directory_namespace_…
erikmej-code Jan 22, 2025
37710b3
Update product.yaml
erikmej-code Jan 22, 2025
801f664
Update Namespace.yaml
erikmej-code Jan 22, 2025
3b8760a
Update service_directory_namespace_basic.tf.tmpl
erikmej-code Jan 31, 2025
1425121
Update sd_full_url.tmpl
erikmej-code Jan 31, 2025
faf3624
Update Namespace.yaml
erikmej-code Jan 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 10 additions & 6 deletions mmv1/products/servicedirectory/Namespace.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ name: 'Namespace'
description: |
A container for `services`. Namespaces allow administrators to group services
together and define permissions for a collection of services.
min_version: 'beta'
references:
guides:
'Configuring a namespace': 'https://cloud.google.com/service-directory/docs/configuring-service-directory#configuring_a_namespace'
Expand Down Expand Up @@ -45,17 +44,19 @@ exclude_sweeper: true
examples:
- name: 'service_directory_namespace_basic'
primary_resource_id: 'example'
min_version: 'beta'
vars:
namespace_id: 'example-namespace'
- name: 'service_directory_namespace_ga'
primary_resource_id: 'example-ga'
vars:
namespace_id: 'example-namespace-ga'
erikmej-code marked this conversation as resolved.
Show resolved Hide resolved
parameters:
- name: 'location'
type: String
description: |
The location for the Namespace.
A full list of valid locations can be found by running
`gcloud beta service-directory locations list`.
min_version: 'beta'
url_param_only: true
required: true
immutable: true
Expand All @@ -65,7 +66,6 @@ parameters:
description: |
The Resource ID must be 1-63 characters long, including digits,
lowercase letters or the hyphen character.
min_version: 'beta'
url_param_only: true
required: true
immutable: true
Expand All @@ -77,12 +77,16 @@ properties:
description: |
The resource name for the namespace
in the format `projects/*/locations/*/namespaces/*`.
min_version: 'beta'
output: true
- name: 'labels'
type: KeyValueLabels
description: |
Resource labels associated with this Namespace. No more than 64 user
labels can be associated with a given resource. Label keys and values can
be no longer than 63 characters.
min_version: 'beta'
- name: 'uid'
Copy link
Member

@shuyama1 shuyama1 Jan 22, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any particular reason this is only added to GA? Is this field not supported by the beta API? We require beta provider to be a strict superset of GA, which means whatever in GA should be in beta as well. See 3.2 in https://googlecloudplatform.github.io/magic-modules/code-review/review-pr/#review

You'll likely need to remove this field from the GA implementation as well.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will fix.

type: String
description: |
The unique identifier of the namespace.
output: true
exact_version: 'ga'
2 changes: 2 additions & 0 deletions mmv1/products/servicedirectory/product.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,5 +17,7 @@ display_name: 'Service Directory'
versions:
- name: 'beta'
base_url: 'https://servicedirectory.googleapis.com/v1beta1/'
- name: 'ga'
base_url: 'https://servicedirectory.googleapis.com/v1/'
scopes:
- 'https://www.googleapis.com/auth/cloud-platform'
Loading