Promoting namespace to the GA provider #12644

erikmej-code · 2024-12-23T19:58:32Z

In an effort to promote the namespace to the GA provider we do the following:

Remove instances of min_version from Namespace.yaml and include the uid field within properties.
Include a test file, service_directory_namespace_ga.tf.tmpl, with the provider omitted.

`google_service_directory_namespace` (GA)

Add example file where provider is omitted.

Update `Namespace.yaml` to include the `uid` property and remove instances of `min_version`.

github-actions · 2024-12-23T19:59:10Z

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@shuyama1, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

github-actions · 2024-12-26T09:40:55Z

@shuyama1 This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

mmv1/templates/terraform/examples/service_directory_namespace_ga.tf.tmpl

shuyama1

You'll also need to add a GA endpoint in https://github.com/GoogleCloudPlatform/magic-modules/blob/main/mmv1/products/servicedirectory/product.yaml

github-actions · 2025-01-09T09:41:31Z

@erikmej-code, this PR is waiting for action from you. If no action is taken, this PR will be closed in 28 days.

Please address any comments or change requests, or re-request review from a core reviewer if no action is required.

This notification can be disabled with the disable-automatic-closure label.

…ga.tf.tmpl Removing file. Not needed.

erikmej-code · 2025-01-22T15:53:05Z

Updated product.yaml file.

mmv1/products/servicedirectory/Namespace.yaml

modular-magician · 2025-01-22T19:26:18Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 14 files changed, 1042 insertions(+), 14 deletions(-))
google-beta provider: Diff ( 5 files changed, 4 insertions(+), 23 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 4 insertions(+))

modular-magician · 2025-01-22T19:29:02Z

Tests analytics

Total tests: 13
Passed tests: 9
Skipped tests: 0
Affected tests: 4

Click here to see the affected service packages

servicedirectory

#### Non-exercised tests

🔴 Tests were added that are GA-only additions and require manual runs:

TestAccServiceDirectoryNamespaceIamBindingGenerated
TestAccServiceDirectoryNamespaceIamMemberGenerated
TestAccServiceDirectoryNamespaceIamPolicyGenerated
TestAccServiceDirectoryNamespace_serviceDirectoryNamespaceBasicExample

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccServiceDirectoryNamespaceIamBindingGenerated

TestAccServiceDirectoryNamespaceIamMemberGenerated

TestAccServiceDirectoryNamespaceIamPolicyGenerated

TestAccServiceDirectoryNamespace_serviceDirectoryNamespaceBasicExample

Get to know how VCR tests work

modular-magician · 2025-01-22T19:29:16Z

🔴 Tests failed during RECORDING mode:
TestAccServiceDirectoryNamespaceIamBindingGenerated [Error message] [Debug log]
TestAccServiceDirectoryNamespaceIamMemberGenerated [Error message] [Debug log]
TestAccServiceDirectoryNamespaceIamPolicyGenerated [Error message] [Debug log]
TestAccServiceDirectoryNamespace_serviceDirectoryNamespaceBasicExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

shuyama1

You'll need to remove the provider = google-beta in the example file https://github.com/GoogleCloudPlatform/magic-modules/blob/main/mmv1/templates/terraform/examples/service_directory_namespace_basic.tf.tmpl#L2, as the example will now be used for GA as well

shuyama1 · 2025-01-22T19:17:58Z

mmv1/products/servicedirectory/Namespace.yaml

    output: true
  - name: 'labels'
    type: KeyValueLabels
    description: |
      Resource labels associated with this Namespace. No more than 64 user
      labels can be associated with a given resource. Label keys and values can
      be no longer than 63 characters.
-    min_version: 'beta'
+  - name: 'uid'


Any particular reason this is only added to GA? Is this field not supported by the beta API? We require beta provider to be a strict superset of GA, which means whatever in GA should be in beta as well. See 3.2 in https://googlecloudplatform.github.io/magic-modules/code-review/review-pr/#review

You'll likely need to remove this field from the GA implementation as well.

modular-magician · 2025-01-31T11:41:39Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 14 files changed, 1036 insertions(+), 15 deletions(-))
google-beta provider: Diff ( 5 files changed, 4 insertions(+), 30 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 4 insertions(+))
Open in Cloud Shell: Diff ( 1 file changed, 1 deletion(-))

modular-magician · 2025-01-31T11:44:19Z

Tests analytics

Total tests: 13
Passed tests: 13
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages

servicedirectory

#### Non-exercised tests

🔴 Tests were added that are GA-only additions and require manual runs:

TestAccServiceDirectoryNamespaceIamBindingGenerated
TestAccServiceDirectoryNamespaceIamMemberGenerated
TestAccServiceDirectoryNamespaceIamPolicyGenerated
TestAccServiceDirectoryNamespace_serviceDirectoryNamespaceBasicExample
🟢 All tests passed!

View the build log

HArdcode v1 service directory base path.

erikmej-code · 2025-01-31T11:54:18Z

@shuyama1 these comments should now be resolved. Please review at your earliest convenience. Thanks!

modular-magician · 2025-01-31T11:58:44Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 14 files changed, 1036 insertions(+), 15 deletions(-))
google-beta provider: Diff ( 6 files changed, 5 insertions(+), 31 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 5 insertions(+), 1 deletion(-))
Open in Cloud Shell: Diff ( 1 file changed, 1 deletion(-))

modular-magician · 2025-01-31T12:03:08Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 14 files changed, 1023 insertions(+), 15 deletions(-))
google-beta provider: Diff ( 6 files changed, 5 insertions(+), 31 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 5 insertions(+), 1 deletion(-))
Open in Cloud Shell: Diff ( 1 file changed, 1 deletion(-))

modular-magician · 2025-01-31T12:03:12Z

Tests analytics

Total tests: 60
Passed tests: 58
Skipped tests: 1
Affected tests: 1

Click here to see the affected service packages

dns

servicedirectory

#### Non-exercised tests

🔴 Tests were added that are GA-only additions and require manual runs:

TestAccServiceDirectoryNamespaceIamBindingGenerated
TestAccServiceDirectoryNamespaceIamMemberGenerated
TestAccServiceDirectoryNamespaceIamPolicyGenerated
TestAccServiceDirectoryNamespace_serviceDirectoryNamespaceBasicExample

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccDNSManagedZone_dnsManagedZoneServiceDirectoryExample

Get to know how VCR tests work

modular-magician · 2025-01-31T12:04:39Z

🟢 Tests passed during RECORDING mode:
TestAccDNSManagedZone_dnsManagedZoneServiceDirectoryExample [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

🟢 All tests passed!

View the build log or the debug log for each test

modular-magician · 2025-01-31T12:07:29Z

Tests analytics

Total tests: 60
Passed tests: 59
Skipped tests: 1
Affected tests: 0

Click here to see the affected service packages

dns

servicedirectory

#### Non-exercised tests

🔴 Tests were added that are GA-only additions and require manual runs:

TestAccServiceDirectoryNamespaceIamBindingGenerated
TestAccServiceDirectoryNamespaceIamMemberGenerated
TestAccServiceDirectoryNamespaceIamPolicyGenerated
TestAccServiceDirectoryNamespace_serviceDirectoryNamespaceBasicExample
🟢 All tests passed!

View the build log

shuyama1 · 2025-01-31T19:50:34Z

mmv1/templates/terraform/custom_expand/sd_full_url.tmpl

@@ -4,7 +4,7 @@ func expand{{$.GetPrefix}}{{$.TitlelizeProperty}}(v interface{}, d tpgresource.T
  } else if strings.HasPrefix(v.(string), "https://") {
    return v, nil
  }
-  url, err := tpgresource.ReplaceVars(d, config, "{{"{{"}}ServiceDirectoryBasePath{{"}}"}}" + v.(string))


We generally aim to keep each PR focused on a single change to make issue detection and revert easier. Since this change is separate from the GA promotion, I’ve moved it to a new PR (#12934) and added tests to verify the fix. We can remove this change from the current PR and proceed with the other PR for the basepath override. Please let me know if it works for you. Thanks!

github-actions · 2025-02-14T09:41:49Z

@erikmej-code, this PR is waiting for action from you. If no action is taken, this PR will be closed in 28 days.

Please address any comments or change requests, or re-request review from a core reviewer if no action is required.

This notification can be disabled with the disable-automatic-closure label.

erikmej-code added 2 commits December 23, 2024 13:50

Create service_directory_namespace_ga.tf.tmpl

e1b2d6e

Add example file where provider is omitted.

Update Namespace.yaml

8f21d5d

Update `Namespace.yaml` to include the `uid` property and remove instances of `min_version`.

github-actions bot requested a review from shuyama1 December 23, 2024 19:59

modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Dec 23, 2024

modular-magician removed the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Dec 26, 2024

shuyama1 reviewed Dec 26, 2024

View reviewed changes

mmv1/templates/terraform/examples/service_directory_namespace_ga.tf.tmpl Outdated Show resolved Hide resolved

shuyama1 reviewed Dec 26, 2024

View reviewed changes

Delete mmv1/templates/terraform/examples/service_directory_namespace_…

1dc3764

…ga.tf.tmpl Removing file. Not needed.

github-actions bot requested a review from shuyama1 January 22, 2025 15:44

modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Jan 22, 2025

Update product.yaml

37710b3

modular-magician removed the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Jan 22, 2025

shuyama1 reviewed Jan 22, 2025

View reviewed changes

mmv1/products/servicedirectory/Namespace.yaml Outdated Show resolved Hide resolved

Update Namespace.yaml

801f664

github-actions bot requested a review from shuyama1 January 22, 2025 19:15

modular-magician added the service/servicedirectory label Jan 22, 2025

shuyama1 reviewed Jan 22, 2025

View reviewed changes

Update service_directory_namespace_basic.tf.tmpl

3b8760a

github-actions bot requested a review from shuyama1 January 31, 2025 11:31

erikmej-code added 2 commits January 31, 2025 06:47

Update sd_full_url.tmpl

1425121

HArdcode v1 service directory base path.

Update Namespace.yaml

faf3624

shuyama1 requested changes Jan 31, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Promoting namespace to the GA provider #12644

Promoting namespace to the GA provider #12644

erikmej-code commented Dec 23, 2024 •

edited by shuyama1

Loading

github-actions bot commented Dec 23, 2024

github-actions bot commented Dec 26, 2024

shuyama1 left a comment •

edited

Loading

github-actions bot commented Jan 9, 2025

erikmej-code commented Jan 22, 2025

modular-magician commented Jan 22, 2025

modular-magician commented Jan 22, 2025

modular-magician commented Jan 22, 2025

shuyama1 left a comment •

edited

Loading

shuyama1 Jan 22, 2025 •

edited

Loading

erikmej-code Jan 31, 2025

modular-magician commented Jan 31, 2025

modular-magician commented Jan 31, 2025

erikmej-code commented Jan 31, 2025

modular-magician commented Jan 31, 2025

modular-magician commented Jan 31, 2025

modular-magician commented Jan 31, 2025

modular-magician commented Jan 31, 2025

modular-magician commented Jan 31, 2025

shuyama1 Jan 31, 2025

github-actions bot commented Feb 14, 2025

Promoting namespace to the GA provider #12644

Are you sure you want to change the base?

Promoting namespace to the GA provider #12644

Conversation

erikmej-code commented Dec 23, 2024 • edited by shuyama1 Loading

github-actions bot commented Dec 23, 2024

github-actions bot commented Dec 26, 2024

shuyama1 left a comment • edited Loading

Choose a reason for hiding this comment

github-actions bot commented Jan 9, 2025

erikmej-code commented Jan 22, 2025

modular-magician commented Jan 22, 2025

Diff report

modular-magician commented Jan 22, 2025

Tests analytics

Action taken

modular-magician commented Jan 22, 2025

shuyama1 left a comment • edited Loading

Choose a reason for hiding this comment

shuyama1 Jan 22, 2025 • edited Loading

Choose a reason for hiding this comment

erikmej-code Jan 31, 2025

Choose a reason for hiding this comment

modular-magician commented Jan 31, 2025

Diff report

modular-magician commented Jan 31, 2025

Tests analytics

erikmej-code commented Jan 31, 2025

modular-magician commented Jan 31, 2025

Diff report

modular-magician commented Jan 31, 2025

Diff report

modular-magician commented Jan 31, 2025

Tests analytics

Action taken

modular-magician commented Jan 31, 2025

modular-magician commented Jan 31, 2025

Tests analytics

shuyama1 Jan 31, 2025

Choose a reason for hiding this comment

github-actions bot commented Feb 14, 2025

erikmej-code commented Dec 23, 2024 •

edited by shuyama1

Loading

shuyama1 left a comment •

edited

Loading

shuyama1 left a comment •

edited

Loading

shuyama1 Jan 22, 2025 •

edited

Loading