Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add HNS support for storage bucket #11852
feat: add HNS support for storage bucket #11852
Changes from 1 commit
d940e4f
71da0ba
d0efd3c
f876dfc
469834f
4abfd7d
63ebc1a
f110095
7f4d6da
93b765c
88c828d
bd8f3d6
df07e05
317c934
7703675
525dae7
1500c70
9db5781
8da56ed
a580268
f621cfa
baacad5
b8ee11a
f37f638
f195934
8b10c77
34cea0d
8f356bb
1e1dee9
c4db88d
74d39c5
4de8500
d81b07b
57c8683
a3ae2e8
fb569ef
d16b427
3e34a4c
bbbf222
10a5124
e670055
71b0caf
d896091
06fa65b
e102ce2
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'll want to add a DiffSuppressFunc to this top-level field similar to this one: https://github.com/hashicorp/terraform-provider-google-beta/blob/804148d2559f8c6628258cfa232cd81c72ed6233/google-beta/services/container/resource_container_cluster.go#L6814-L6826
We're always storing the full ("hydrated") value in state in our flatten function where null is mapped to an item being present with
enabled = false
, so if we see a diff from.#
(length) of 1 -> 0 andenabled
isfalse
, we can returntrue
from the function to suppress the diff.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added the suggested change for DiffSuppress func