feat: add HNS support for storage bucket #11852

gurusai-voleti · 2024-09-27T07:05:52Z

Adds support to enable hierarchical_namespace for storage buckets

Release Note Template for Downstream PRs (will be copied)

storage: added 'hierarchical_namespace' to 'google_storage_bucket' resource

google-cla · 2024-09-27T07:05:56Z

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

github-actions · 2024-09-27T07:06:33Z

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@rileykarson, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

mmv1/third_party/terraform/services/storage/resource_storage_bucket.go.tmpl

kautikdk · 2024-09-27T07:36:27Z

Apart from the field behavior comments, Please check bucket deletion. If the bucket is configured with force_destroy=true then while deleting bucket, it should delete all the folders and objects within the it. This may require changing logic in deletion operation.
Also please add documentation of the newly added fields and PR description as well.

mmv1/third_party/terraform/services/storage/resource_storage_bucket.go.tmpl

…o.tmpl

gurusai-voleti · 2024-09-30T10:29:48Z

->> ran manual test case locally as below

create HNS enabled bucket with force_destroy=true and upload files in bucket
check bucket is created with contents
when tried to delete bucket, terraform deleted the all the files in bucket and deleted the bucket

so no code changes needed for force_destroy for HNS bucket

update: added force destroy test case in acceptance tests

mmv1/third_party/terraform/services/storage/resource_storage_bucket.go.tmpl

mmv1/third_party/terraform/services/storage/resource_storage_bucket_test.go.tmpl

kautikdk · 2024-10-03T12:26:05Z

/gcbrun

kautikdk · 2024-10-03T12:26:50Z

Hi @rileykarson, Can you please trigger tests for this PR?

gurusai-voleti · 2024-10-04T06:04:35Z

/gcbrun

github-actions · 2024-10-04T09:42:21Z

@GoogleCloudPlatform/terraform-team @rileykarson This PR has been waiting for review for 1 week. Please take a look! Use the label disable-review-reminders to disable these notifications.

modular-magician · 2024-10-16T07:54:14Z

Tests analytics

Total tests: 109
Passed tests: 5
Skipped tests: 9
Affected tests: 95

Click here to see the affected service packages

Action taken

Found 95 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

Get to know how VCR tests work

modular-magician · 2024-10-16T07:54:51Z

Tests analytics

Total tests: 109
Passed tests: 5
Skipped tests: 9
Affected tests: 95

Click here to see the affected service packages

Action taken

Found 95 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

Get to know how VCR tests work

modular-magician · 2024-10-16T07:56:19Z

🔴 Tests failed during RECORDING mode:
TestAccDataSourceGoogleStorageBucketObject_basic[Error message] [Debug log]
TestAccDataSourceGoogleStorageBucketObjects_basic[Error message] [Debug log]
TestAccDataSourceGoogleStorageBucket_avoidComputeAPI[Error message] [Debug log]
TestAccDataSourceGoogleStorageBucket_basic[Error message] [Debug log]
TestAccDataSourceGoogleStorageBuckets_basic[Error message] [Debug log]
TestAccDataSourceStorageBucketObjectContent_Basic[Error message] [Debug log]
TestAccStorageBucketAccessControl_storageBucketAccessControlPublicBucketExample[Error message] [Debug log]
TestAccStorageBucketAccessControl_update[Error message] [Debug log]
TestAccStorageBucketAcl_RemoveOwner[Error message] [Debug log]
TestAccStorageBucketAcl_basic[Error message] [Debug log]
TestAccStorageBucketAcl_downgrade[Error message] [Debug log]
TestAccStorageBucketAcl_predefined[Error message] [Debug log]
TestAccStorageBucketAcl_unordered[Error message] [Debug log]
TestAccStorageBucketAcl_upgrade[Error message] [Debug log]
TestAccStorageBucketAcl_upgradeSingleUser[Error message] [Debug log]
TestAccStorageBucketIamBindingGenerated[Error message] [Debug log]
TestAccStorageBucketIamBindingGenerated_withCondition[Error message] [Debug log]
TestAccStorageBucketIamMemberGenerated[Error message] [Debug log]
TestAccStorageBucketIamMemberGenerated_withCondition[Error message] [Debug log]
TestAccStorageBucketIamPolicy[Error message] [Debug log]
TestAccStorageBucketIamPolicyGenerated[Error message] [Debug log]
TestAccStorageBucketIamPolicyGenerated_withCondition[Error message] [Debug log]
TestAccStorageBucket_AutoclassDiffSupress[Error message] [Debug log]
TestAccStorageBucket_SoftDeletePolicy[Error message] [Debug log]
TestAccStorageBucket_basic[Error message] [Debug log]
TestAccStorageBucket_basicWithAutoclass[Error message] [Debug log]
TestAccStorageBucket_basic_hns[Error message] [Debug log]
TestAccStorageBucket_cors[Error message] [Debug log]
TestAccStorageBucket_customAttributes[Error message] [Debug log]
TestAccStorageBucket_defaultEventBasedHold[Error message] [Debug log]
TestAccStorageBucket_dualLocation[Error message] [Debug log]
TestAccStorageBucket_dualLocation_lowercase[Error message] [Debug log]
TestAccStorageBucket_dualLocation_rpo[Error message] [Debug log]
TestAccStorageBucket_enable_object_retention[Error message] [Debug log]
TestAccStorageBucket_forceDestroy[Error message] [Debug log]
TestAccStorageBucket_forceDestroyObjectDeleteError[Error message] [Debug log]
TestAccStorageBucket_forceDestroyWithVersioning[Error message] [Debug log]
TestAccStorageBucket_labels[Error message] [Debug log]
TestAccStorageBucket_lifecycleRuleStateAny[Error message] [Debug log]
TestAccStorageBucket_lifecycleRuleStateArchived[Error message] [Debug log]
TestAccStorageBucket_lifecycleRuleStateLive[Error message] [Debug log]
TestAccStorageBucket_lifecycleRulesVirtualFields[Error message] [Debug log]
TestAccStorageBucket_logging[Error message] [Debug log]
TestAccStorageBucket_lowercaseLocation[Error message] [Debug log]
TestAccStorageBucket_multiLocation_rpo[Error message] [Debug log]
TestAccStorageBucket_publicAccessPrevention[Error message] [Debug log]
TestAccStorageBucket_requesterPays[Error message] [Debug log]
TestAccStorageBucket_retentionPolicy[Error message] [Debug log]
TestAccStorageBucket_retentionPolicyLocked[Error message] [Debug log]
TestAccStorageBucket_storageClass[Error message] [Debug log]
TestAccStorageBucket_uniformBucketAccessOnly[Error message] [Debug log]
TestAccStorageBucket_update[Error message] [Debug log]
TestAccStorageBucket_update_requesterPays[Error message] [Debug log]
TestAccStorageBucket_versioning[Error message] [Debug log]
TestAccStorageBucket_website[Error message] [Debug log]
TestAccStorageDefaultObjectAccessControl_storageDefaultObjectAccessControlPublicExample[Error message] [Debug log]
TestAccStorageDefaultObjectAccessControl_update[Error message] [Debug log]
TestAccStorageDefaultObjectAcl_basic[Error message] [Debug log]
TestAccStorageDefaultObjectAcl_downgrade[Error message] [Debug log]
TestAccStorageDefaultObjectAcl_noRoleEntity[Error message] [Debug log]
TestAccStorageDefaultObjectAcl_unordered[Error message] [Debug log]
TestAccStorageDefaultObjectAcl_upgrade[Error message] [Debug log]
TestAccStorageManagedFolderIamBindingGenerated[Error message] [Debug log]
TestAccStorageManagedFolderIamBindingGenerated_withCondition[Error message] [Debug log]
TestAccStorageManagedFolderIamMemberGenerated[Error message] [Debug log]
TestAccStorageManagedFolderIamMemberGenerated_withCondition[Error message] [Debug log]
TestAccStorageManagedFolderIamPolicyGenerated[Error message] [Debug log]
TestAccStorageManagedFolderIamPolicyGenerated_withCondition[Error message] [Debug log]
TestAccStorageManagedFolder_storageManagedFolderBasicExample[Error message] [Debug log]
TestAccStorageManagedFolder_storageManagedFolderUpdate[Error message] [Debug log]
TestAccStorageNotification_basic[Error message] [Debug log]
TestAccStorageNotification_withEventsAndAttributes[Error message] [Debug log]
TestAccStorageObjectAccessControl_storageObjectAccessControlPublicObjectExample[Error message] [Debug log]
TestAccStorageObjectAccessControl_update[Error message] [Debug log]
TestAccStorageObjectAccessControl_updateWithSlashes[Error message] [Debug log]
TestAccStorageObjectAcl_basic[Error message] [Debug log]
TestAccStorageObjectAcl_downgrade[Error message] [Debug log]
TestAccStorageObjectAcl_explicitToPredefined[Error message] [Debug log]
TestAccStorageObjectAcl_predefined[Error message] [Debug log]
TestAccStorageObjectAcl_predefinedToExplicit[Error message] [Debug log]
TestAccStorageObjectAcl_unordered[Error message] [Debug log]
TestAccStorageObjectAcl_upgrade[Error message] [Debug log]
TestAccStorageObjectKms[Error message] [Debug log]
TestAccStorageObject_basic[Error message] [Debug log]
TestAccStorageObject_cacheControl[Error message] [Debug log]
TestAccStorageObject_content[Error message] [Debug log]
TestAccStorageObject_customerEncryption[Error message] [Debug log]
TestAccStorageObject_dynamicContent[Error message] [Debug log]
TestAccStorageObject_folder[Error message] [Debug log]
TestAccStorageObject_holds[Error message] [Debug log]
TestAccStorageObject_metadata[Error message] [Debug log]
TestAccStorageObject_recreate[Error message] [Debug log]
TestAccStorageObject_retention[Error message] [Debug log]
TestAccStorageObject_storageClass[Error message] [Debug log]
TestAccStorageObject_withContentCharacteristics[Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2024-10-16T07:56:34Z

🔴 Tests failed during RECORDING mode:
TestAccDataSourceGoogleStorageBucketObject_basic[Error message] [Debug log]
TestAccDataSourceGoogleStorageBucketObjects_basic[Error message] [Debug log]
TestAccDataSourceGoogleStorageBucket_avoidComputeAPI[Error message] [Debug log]
TestAccDataSourceGoogleStorageBucket_basic[Error message] [Debug log]
TestAccDataSourceGoogleStorageBuckets_basic[Error message] [Debug log]
TestAccDataSourceStorageBucketObjectContent_Basic[Error message] [Debug log]
TestAccStorageBucketAccessControl_storageBucketAccessControlPublicBucketExample[Error message] [Debug log]
TestAccStorageBucketAccessControl_update[Error message] [Debug log]
TestAccStorageBucketAcl_RemoveOwner[Error message] [Debug log]
TestAccStorageBucketAcl_basic[Error message] [Debug log]
TestAccStorageBucketAcl_downgrade[Error message] [Debug log]
TestAccStorageBucketAcl_predefined[Error message] [Debug log]
TestAccStorageBucketAcl_unordered[Error message] [Debug log]
TestAccStorageBucketAcl_upgrade[Error message] [Debug log]
TestAccStorageBucketAcl_upgradeSingleUser[Error message] [Debug log]
TestAccStorageBucketIamBindingGenerated[Error message] [Debug log]
TestAccStorageBucketIamBindingGenerated_withCondition[Error message] [Debug log]
TestAccStorageBucketIamMemberGenerated[Error message] [Debug log]
TestAccStorageBucketIamMemberGenerated_withCondition[Error message] [Debug log]
TestAccStorageBucketIamPolicy[Error message] [Debug log]
TestAccStorageBucketIamPolicyGenerated[Error message] [Debug log]
TestAccStorageBucketIamPolicyGenerated_withCondition[Error message] [Debug log]
TestAccStorageBucket_AutoclassDiffSupress[Error message] [Debug log]
TestAccStorageBucket_SoftDeletePolicy[Error message] [Debug log]
TestAccStorageBucket_basic[Error message] [Debug log]
TestAccStorageBucket_basicWithAutoclass[Error message] [Debug log]
TestAccStorageBucket_basic_hns[Error message] [Debug log]
TestAccStorageBucket_cors[Error message] [Debug log]
TestAccStorageBucket_customAttributes[Error message] [Debug log]
TestAccStorageBucket_defaultEventBasedHold[Error message] [Debug log]
TestAccStorageBucket_dualLocation[Error message] [Debug log]
TestAccStorageBucket_dualLocation_lowercase[Error message] [Debug log]
TestAccStorageBucket_dualLocation_rpo[Error message] [Debug log]
TestAccStorageBucket_enable_object_retention[Error message] [Debug log]
TestAccStorageBucket_forceDestroy[Error message] [Debug log]
TestAccStorageBucket_forceDestroyObjectDeleteError[Error message] [Debug log]
TestAccStorageBucket_forceDestroyWithVersioning[Error message] [Debug log]
TestAccStorageBucket_labels[Error message] [Debug log]
TestAccStorageBucket_lifecycleRuleStateAny[Error message] [Debug log]
TestAccStorageBucket_lifecycleRuleStateArchived[Error message] [Debug log]
TestAccStorageBucket_lifecycleRuleStateLive[Error message] [Debug log]
TestAccStorageBucket_lifecycleRulesVirtualFields[Error message] [Debug log]
TestAccStorageBucket_logging[Error message] [Debug log]
TestAccStorageBucket_lowercaseLocation[Error message] [Debug log]
TestAccStorageBucket_multiLocation_rpo[Error message] [Debug log]
TestAccStorageBucket_publicAccessPrevention[Error message] [Debug log]
TestAccStorageBucket_requesterPays[Error message] [Debug log]
TestAccStorageBucket_retentionPolicy[Error message] [Debug log]
TestAccStorageBucket_retentionPolicyLocked[Error message] [Debug log]
TestAccStorageBucket_storageClass[Error message] [Debug log]
TestAccStorageBucket_uniformBucketAccessOnly[Error message] [Debug log]
TestAccStorageBucket_update[Error message] [Debug log]
TestAccStorageBucket_update_requesterPays[Error message] [Debug log]
TestAccStorageBucket_versioning[Error message] [Debug log]
TestAccStorageBucket_website[Error message] [Debug log]
TestAccStorageDefaultObjectAccessControl_storageDefaultObjectAccessControlPublicExample[Error message] [Debug log]
TestAccStorageDefaultObjectAccessControl_update[Error message] [Debug log]
TestAccStorageDefaultObjectAcl_basic[Error message] [Debug log]
TestAccStorageDefaultObjectAcl_downgrade[Error message] [Debug log]
TestAccStorageDefaultObjectAcl_noRoleEntity[Error message] [Debug log]
TestAccStorageDefaultObjectAcl_unordered[Error message] [Debug log]
TestAccStorageDefaultObjectAcl_upgrade[Error message] [Debug log]
TestAccStorageManagedFolderIamBindingGenerated[Error message] [Debug log]
TestAccStorageManagedFolderIamBindingGenerated_withCondition[Error message] [Debug log]
TestAccStorageManagedFolderIamMemberGenerated[Error message] [Debug log]
TestAccStorageManagedFolderIamMemberGenerated_withCondition[Error message] [Debug log]
TestAccStorageManagedFolderIamPolicyGenerated[Error message] [Debug log]
TestAccStorageManagedFolderIamPolicyGenerated_withCondition[Error message] [Debug log]
TestAccStorageManagedFolder_storageManagedFolderBasicExample[Error message] [Debug log]
TestAccStorageManagedFolder_storageManagedFolderUpdate[Error message] [Debug log]
TestAccStorageNotification_basic[Error message] [Debug log]
TestAccStorageNotification_withEventsAndAttributes[Error message] [Debug log]
TestAccStorageObjectAccessControl_storageObjectAccessControlPublicObjectExample[Error message] [Debug log]
TestAccStorageObjectAccessControl_update[Error message] [Debug log]
TestAccStorageObjectAccessControl_updateWithSlashes[Error message] [Debug log]
TestAccStorageObjectAcl_basic[Error message] [Debug log]
TestAccStorageObjectAcl_downgrade[Error message] [Debug log]
TestAccStorageObjectAcl_explicitToPredefined[Error message] [Debug log]
TestAccStorageObjectAcl_predefined[Error message] [Debug log]
TestAccStorageObjectAcl_predefinedToExplicit[Error message] [Debug log]
TestAccStorageObjectAcl_unordered[Error message] [Debug log]
TestAccStorageObjectAcl_upgrade[Error message] [Debug log]
TestAccStorageObjectKms[Error message] [Debug log]
TestAccStorageObject_basic[Error message] [Debug log]
TestAccStorageObject_cacheControl[Error message] [Debug log]
TestAccStorageObject_content[Error message] [Debug log]
TestAccStorageObject_customerEncryption[Error message] [Debug log]
TestAccStorageObject_dynamicContent[Error message] [Debug log]
TestAccStorageObject_folder[Error message] [Debug log]
TestAccStorageObject_holds[Error message] [Debug log]
TestAccStorageObject_metadata[Error message] [Debug log]
TestAccStorageObject_recreate[Error message] [Debug log]
TestAccStorageObject_retention[Error message] [Debug log]
TestAccStorageObject_storageClass[Error message] [Debug log]
TestAccStorageObject_withContentCharacteristics[Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2024-10-16T09:40:57Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 228 insertions(+))
google-beta provider: Diff ( 3 files changed, 228 insertions(+))

modular-magician · 2024-10-16T09:49:10Z

Tests analytics

Total tests: 109
Passed tests: 99
Skipped tests: 9
Affected tests: 1

Click here to see the affected service packages

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

Get to know how VCR tests work

modular-magician · 2024-10-16T09:50:00Z

🟢 Tests passed during RECORDING mode:
TestAccStorageBucket_basic_hns[Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

🟢 All tests passed!

View the build log or the debug log for each test

modular-magician · 2024-10-16T10:07:31Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 241 insertions(+))
google-beta provider: Diff ( 3 files changed, 241 insertions(+))

modular-magician · 2024-10-16T10:09:55Z

Tests analytics

Total tests: 0
Passed tests: 0
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages

#### Non-exercised tests

🔴 Tests were added that are skipped in VCR:

TestAccStorageBucket_basic_hns
TestAccStorageBucket_hns_force_destroy
🔴 Errors occurred during REPLAYING mode. Please fix them to complete your PR.

View the build log

modular-magician · 2024-10-16T10:33:07Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 242 insertions(+))
google-beta provider: Diff ( 3 files changed, 242 insertions(+))

modular-magician · 2024-10-16T10:41:17Z

Tests analytics

Total tests: 109
Passed tests: 99
Skipped tests: 9
Affected tests: 1

Click here to see the affected service packages

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

Get to know how VCR tests work

modular-magician · 2024-10-16T10:41:43Z

🔴 Tests failed during RECORDING mode:
TestAccStorageBucket_basic_hns[Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2024-10-16T11:07:21Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 232 insertions(+))
google-beta provider: Diff ( 3 files changed, 232 insertions(+))

modular-magician · 2024-10-16T11:16:18Z

Tests analytics

Total tests: 109
Passed tests: 100
Skipped tests: 9
Affected tests: 0

Click here to see the affected service packages

🟢 All tests passed!

View the build log

rileykarson

LGTM, thanks!

Co-authored-by: Riley Karson <[email protected]>

hns bucket

d940e4f

github-actions bot requested a review from rileykarson September 27, 2024 07:06

modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Sep 27, 2024

gurusai-voleti marked this pull request as draft September 27, 2024 07:26

kautikdk reviewed Sep 27, 2024

View reviewed changes

mmv1/third_party/terraform/services/storage/resource_storage_bucket.go.tmpl Outdated Show resolved Hide resolved

kautikdk reviewed Sep 27, 2024

View reviewed changes

mmv1/third_party/terraform/services/storage/resource_storage_bucket.go.tmpl Outdated Show resolved Hide resolved

mmv1/third_party/terraform/services/storage/resource_storage_bucket.go.tmpl Outdated Show resolved Hide resolved

gurusai-voleti added 3 commits September 27, 2024 09:49

mmv1/third_party/terraform/services/storage/resource_storage_bucket.g…

71da0ba

…o.tmpl

remove default

d0efd3c

Merge branch 'GoogleCloudPlatform:main' into main

f876dfc

gurusai-voleti added 4 commits September 30, 2024 12:27

add force destroy test case

469834f

update

4abfd7d

corrected params

63ebc1a

update documentation

f110095

kautikdk reviewed Sep 30, 2024

View reviewed changes

gurusai-voleti added 3 commits September 30, 2024 16:11

add example for hns

7f4d6da

remove checking change of hns in update block

93b765c

add hns bucket with false testcase

88c828d

gurusai-voleti requested a review from kautikdk October 3, 2024 06:37

gurusai-voleti marked this pull request as ready for review October 3, 2024 11:24

gurusai-voleti added 2 commits October 3, 2024 14:29

Merge branch 'GoogleCloudPlatform:main' into main

bd8f3d6

Merge branch 'GoogleCloudPlatform:main' into main

df07e05

Merge branch 'GoogleCloudPlatform:main' into main

317c934

gurusai-voleti added 2 commits October 16, 2024 09:29

updates

e670055

Merge branch 'main' of github.com:gurusai-voleti/magic-modules

71b0caf

update no plan test case

d896091

add missing import

06fa65b

update test case

e102ce2

rileykarson approved these changes Oct 16, 2024

View reviewed changes

rileykarson merged commit 7850733 into GoogleCloudPlatform:main Oct 16, 2024
11 checks passed

This was referenced Oct 16, 2024

feat: add HNS support for storage bucket hashicorp/terraform-provider-google#19882

Merged

feat: add HNS support for storage bucket hashicorp/terraform-provider-google-beta#8428

Merged

gontech pushed a commit to gontech/magic-modules that referenced this pull request Oct 16, 2024

feat: add HNS support for storage bucket (GoogleCloudPlatform#11852)

f7dcbb9

Co-authored-by: Riley Karson <[email protected]>

varshatumburu pushed a commit to varshatumburu/magic-modules that referenced this pull request Oct 19, 2024

feat: add HNS support for storage bucket (GoogleCloudPlatform#11852)

f7d4144

Co-authored-by: Riley Karson <[email protected]>

BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Oct 23, 2024

feat: add HNS support for storage bucket (GoogleCloudPlatform#11852)

e07ab13

Co-authored-by: Riley Karson <[email protected]>

BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Oct 24, 2024

feat: add HNS support for storage bucket (GoogleCloudPlatform#11852)

907ef11

Co-authored-by: Riley Karson <[email protected]>

BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Nov 5, 2024

feat: add HNS support for storage bucket (GoogleCloudPlatform#11852)

08df1dc

Co-authored-by: Riley Karson <[email protected]>

akshat-jindal-nit pushed a commit to akshat-jindal-nit/magic-modules that referenced this pull request Nov 18, 2024

feat: add HNS support for storage bucket (GoogleCloudPlatform#11852)

de5239c

Co-authored-by: Riley Karson <[email protected]>

amanMahendroo pushed a commit to amanMahendroo/magic-modules that referenced this pull request Dec 17, 2024

feat: add HNS support for storage bucket (GoogleCloudPlatform#11852)

edcd985

Co-authored-by: Riley Karson <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add HNS support for storage bucket #11852

feat: add HNS support for storage bucket #11852

gurusai-voleti commented Sep 27, 2024 •

edited

Loading

google-cla bot commented Sep 27, 2024

github-actions bot commented Sep 27, 2024

kautikdk commented Sep 27, 2024

gurusai-voleti commented Sep 30, 2024 •

edited

Loading

kautikdk commented Oct 3, 2024

kautikdk commented Oct 3, 2024

gurusai-voleti commented Oct 4, 2024

github-actions bot commented Oct 4, 2024

modular-magician commented Oct 16, 2024

modular-magician commented Oct 16, 2024

modular-magician commented Oct 16, 2024

modular-magician commented Oct 16, 2024

modular-magician commented Oct 16, 2024

modular-magician commented Oct 16, 2024

modular-magician commented Oct 16, 2024

modular-magician commented Oct 16, 2024

modular-magician commented Oct 16, 2024

modular-magician commented Oct 16, 2024

modular-magician commented Oct 16, 2024

modular-magician commented Oct 16, 2024

modular-magician commented Oct 16, 2024

modular-magician commented Oct 16, 2024

rileykarson left a comment

feat: add HNS support for storage bucket #11852

feat: add HNS support for storage bucket #11852

Conversation

gurusai-voleti commented Sep 27, 2024 • edited Loading

google-cla bot commented Sep 27, 2024

github-actions bot commented Sep 27, 2024

kautikdk commented Sep 27, 2024

gurusai-voleti commented Sep 30, 2024 • edited Loading

kautikdk commented Oct 3, 2024

kautikdk commented Oct 3, 2024

gurusai-voleti commented Oct 4, 2024

github-actions bot commented Oct 4, 2024

modular-magician commented Oct 16, 2024

Tests analytics

Action taken

modular-magician commented Oct 16, 2024

Tests analytics

Action taken

modular-magician commented Oct 16, 2024

modular-magician commented Oct 16, 2024

modular-magician commented Oct 16, 2024

Diff report

modular-magician commented Oct 16, 2024

Tests analytics

Action taken

modular-magician commented Oct 16, 2024

modular-magician commented Oct 16, 2024

Diff report

modular-magician commented Oct 16, 2024

Tests analytics

modular-magician commented Oct 16, 2024

Diff report

modular-magician commented Oct 16, 2024

Tests analytics

Action taken

modular-magician commented Oct 16, 2024

modular-magician commented Oct 16, 2024

Diff report

modular-magician commented Oct 16, 2024

Tests analytics

rileykarson left a comment

Choose a reason for hiding this comment

gurusai-voleti commented Sep 27, 2024 •

edited

Loading

gurusai-voleti commented Sep 30, 2024 •

edited

Loading