Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs for new image types support for VmwareNodePool #11643

Merged
merged 2 commits into from
Sep 6, 2024
Merged

Update docs for new image types support for VmwareNodePool #11643

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
113a76e
Update VmwareNodePool.yaml
naitianliu-google Sep 5, 2024
218c111
Merge pull request #3 from naitianliu-google/naitianliu-google-patch-2
naitianliu-google Sep 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion mmv1/products/gkeonprem/VmwareNodePool.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ properties:
required: true
description: |
The OS image to be used for each node in a node pool.
Currently `cos`, `ubuntu`, `ubuntu_containerd` and `windows` are supported.
Currently `cos`, `cos_cgv2`, `ubuntu`, `ubuntu_cgv2`, `ubuntu_containerd` and `windows` are supported.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you provide me a link of where it talks about the inclusion of these new node image types?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for asking. Here is the context of this change b/348187956

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry I don't have access to the link, is this not made public yet?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The public API doc also needs to be updated in parallel as well. https://cloud.google.com/anthos/clusters/docs/on-prem-api/reference/rest/v1/projects.locations.vmwareClusters.vmwareNodePools#VmwareNodeConfig

But you can refer to this doc on platform side https://cloud.google.com/kubernetes-engine/distributed-cloud/vmware/docs/how-to/user-cluster-configuration-file-latest#nodepool-osimage-field

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was helpful, thanks!!

- !ruby/object:Api::Type::String
name: "image"
description: The OS image name in vCenter, only valid when using Windows.
Expand Down
Loading